From owner-freebsd-multimedia Tue Mar 24 14:16:05 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id OAA09640 for freebsd-multimedia-outgoing; Tue, 24 Mar 1998 14:16:05 -0800 (PST) (envelope-from owner-freebsd-multimedia@FreeBSD.ORG) Received: from taliesin.cs.ucla.edu (Taliesin.CS.UCLA.EDU [131.179.96.166]) by hub.freebsd.org (8.8.8/8.8.8) with SMTP id OAA09634 for ; Tue, 24 Mar 1998 14:16:04 -0800 (PST) (envelope-from scottm@mordred.cs.ucla.edu) Received: (qmail 3699 invoked from network); 24 Mar 1998 22:15:24 -0000 Received: from mordred.cs.ucla.edu (131.179.48.34) by taliesin.cs.ucla.edu with SMTP; 24 Mar 1998 22:15:24 -0000 Received: (from scottm@localhost) by mordred.cs.ucla.edu (8.8.8/8.8.8) id OAA00506 for freebsd-multimedia@freebsd.org; Tue, 24 Mar 1998 14:15:58 -0800 (PST) (envelope-from scottm) Date: Tue, 24 Mar 1998 14:15:58 -0800 (PST) From: Scott Michel Message-Id: <199803242215.OAA00506@mordred.cs.ucla.edu> To: freebsd-multimedia@FreeBSD.ORG Subject: NEC 276 CDrom drive Sender: owner-freebsd-multimedia@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org I brought this up on this list a few months ago, and now with a minor lull in my courses, I did some debugging. I'd been getting "unknown phase" errors and was told that this was due to latency in the controller. It's not. It's due to a strong predicate in atapi.c. I changed #define PHASE_COMPLETED (ARI_IN | ARI_CMD) to #define PHASE_COMPLETED (ARI_CMD) and the unknown phase (the more common problem for me) goes away. Apparently, the controller doesn't assert ARI_IN when the ATAPI_MODE_SENSE command is done. Question: Is this change to PHASE_COMPLETED, albeit a weaker predicate, safe? And can someone commit this change to -current? -scooter -- Scott Michel | In life, there are sheep and there are UCLA Computer Science | wolves. PhD Graduate Student | ... And I don't bleed ... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-multimedia" in the body of the message