From owner-freebsd-bugs@FreeBSD.ORG Fri Jun 20 22:50:37 2008 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68628106566B for ; Fri, 20 Jun 2008 22:50:37 +0000 (UTC) (envelope-from gonzo@freebsd.org) Received: from luidgi.portaone.com (luidgi.portaone.com [195.138.219.143]) by mx1.freebsd.org (Postfix) with ESMTP id 490B68FC13 for ; Fri, 20 Jun 2008 22:50:37 +0000 (UTC) (envelope-from gonzo@freebsd.org) Received: from mail.pbxpress.com ([65.61.203.142] helo=leaf.pbxpress.com) by luidgi.portaone.com (8.11.3/8.11.3) with ESMTP (TLSv1:AES256-SHA:256)id 1K9pEB-000Mt7-Db; Fri, 20 Jun 2008 15:37:07 -0700 Received: from jeeves.bluezbox.com (82.193.112.144.ipnet.kiev.ua [82.193.112.144]) (authenticated bits=0) by leaf.pbxpress.com (8.13.3/8.13.3) with ESMTP id m5KMf1mL036299 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 20 Jun 2008 15:41:16 -0700 (PDT) (envelope-from gonzo@freebsd.org) Message-ID: <485C311A.70203@freebsd.org> Date: Sat, 21 Jun 2008 01:37:14 +0300 From: Oleksandr Tymoshenko User-Agent: Thunderbird 2.0.0.6 (X11/20070907) MIME-Version: 1.0 To: Garrett Cooper References: <200806190350.m5J3o37a007822@freefall.freebsd.org> In-Reply-To: <200806190350.m5J3o37a007822@freefall.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, recieved from trusted server Cc: freebsd-bugs@freebsd.org Subject: Re: kern/124723: Typo in error message in ggated.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jun 2008 22:50:37 -0000 Garrett Cooper wrote: > That error message (IMO) is in and of itself misleading. > > strerror(errno) with g_gate_xlog(...) would be a more suitable means > of denoting the error encountered. No point in strerror. Both malloc and strdup set errno only to ENOMEM. Committed as is. -- gonzo