Date: Wed, 23 Jun 2004 00:04:06 +0100 From: Bruce M Simpson <bms@spc.org> To: Christian Weisgerber <naddy@mips.inka.de> Cc: freebsd-current@freebsd.org Subject: Re: Optimized ether_crc32_be() Message-ID: <20040622230406.GJ762@empiric.dek.spc.org> In-Reply-To: <cavuc4$2bvn$1@kemoauc.mips.inka.de> References: <cavuc4$2bvn$1@kemoauc.mips.inka.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 18, 2004 at 11:37:40PM +0000, Christian Weisgerber wrote: > Taken from kern/49957, here's a table-driven implementation of > ether_crc32_be() to complement the little-endian one. For 6-byte > MAC addresses it's about five times faster than the double loop. > > Comments? This sounds like a good idea. I'd be happy to see this committed (providing, as phk@ suggested, that it is subject to proper regression testing) as it may help to address the GPL contamination thread discussed in May's Core Monthly Report (specifically in sk(4)). Also, the reduction of code duplication can only be a good thing. Regards, BMS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040622230406.GJ762>