From owner-svn-src-all@freebsd.org Wed Oct 2 14:12:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 80B47130224; Wed, 2 Oct 2019 14:12:12 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46jykg1xbMz4TGQ; Wed, 2 Oct 2019 14:12:10 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi1-f169.google.com with SMTP id k25so17700269oiw.13; Wed, 02 Oct 2019 07:12:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LInN2EeMNRaWbQ7PtQgLRQFVHHSGsYYRDbf8CR0UPGQ=; b=qbaoqfBr3Ft/S6Tkq/pmnfRWc3lhXmuLNu3Rwun5DsgkeiOOA8Y47zHh14m54o9mYX 1TTFSxmPtFkrutkm6Gppv9xQ4uOfRa+550oB/v6mIqf/Qj5uDGotfNbUylUM0DKyrOMa Nwy7WrhdbI8BPKmkh6irHPo0RNWKqPHyN/zESfokJCsBY7ZZ2FoGI6nNA+ZMIqDkCzpj OACWYvd6AUl9LtzyVgmUTG01j8Kb0Z6YJkueTh8bUU/9ldTwoq22J2cfdS/sNla6yMQd t+eAOl3eLEc7U9Wn/0VkqBHuZFesyg7k/L7sTvIn26zplKBnmKOY4752NYDR6I7cSh3s 4SPA== X-Gm-Message-State: APjAAAWWVA2pyWCm7Hd7f67FTFZz7Ce6k6CNllieVLn4EDSVRRlxxDSY AWaSXA3oCjJC0Gk/Dk9lbEf3TkTYrOOcYNEsILRKoNL6 X-Google-Smtp-Source: APXvYqzrdmXdKsQbg7J2HU1/wGm3DRtg+fsiyD4685Fid65picFViQkyIxwCXZy4tXkHIKqDF0CN4X3aycCWG5VEMzI= X-Received: by 2002:aca:f48e:: with SMTP id s136mr3104902oih.57.1570025529122; Wed, 02 Oct 2019 07:12:09 -0700 (PDT) MIME-Version: 1.0 References: <201909132303.x8DN3uw3026373@repo.freebsd.org> In-Reply-To: <201909132303.x8DN3uw3026373@repo.freebsd.org> From: Alan Somers Date: Wed, 2 Oct 2019 08:11:57 -0600 Message-ID: Subject: Re: svn commit: r352312 - in head: lib/geom/nop sys/geom/nop To: Chuck Silvers Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 46jykg1xbMz4TGQ X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.169 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.18 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-1.18)[ip: (-0.44), ipnet: 209.85.128.0/17(-3.27), asn: 15169(-2.16), country: US(-0.05)]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[169.167.85.209.list.dnswl.org : 127.0.5.0]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[169.167.85.209.rep.mailspike.net : 127.0.0.17]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Oct 2019 14:12:12 -0000 On Fri, Sep 13, 2019 at 5:04 PM Chuck Silvers wrote: > Author: chs > Date: Fri Sep 13 23:03:56 2019 > New Revision: 352312 > URL: https://svnweb.freebsd.org/changeset/base/352312 > > Log: > Add a "count_until_fail" option to gnop, which says to start failing > I/O requests after the given number have been allowed though. > > Approved by: imp (mentor) > Reviewed by: rpokala kib 0mp mckusick > Sponsored by: Netflix > Differential Revision: https://reviews.freebsd.org/D21593 > > Modified: > head/lib/geom/nop/geom_nop.c > head/lib/geom/nop/gnop.8 > head/sys/geom/nop/g_nop.c > head/sys/geom/nop/g_nop.h > This patch introduces a backwards-compatibility bug. On a system with a post-352312 kernel but a pre-352312 userland, the gnop command will always fail with the error "gnop: Missing count_until_fail argument". -Alan