Date: Tue, 4 Oct 2016 13:53:52 -0700 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Hiren Panchasara <hiren@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r306337 - head/sys/kern Message-ID: <20161004205352.GM23123@FreeBSD.org> In-Reply-To: <201609261013.u8QADwrV002892@repo.freebsd.org> References: <201609261013.u8QADwrV002892@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hiren, On Mon, Sep 26, 2016 at 10:13:58AM +0000, Hiren Panchasara wrote: H> Author: hiren H> Date: Mon Sep 26 10:13:58 2016 H> New Revision: 306337 H> URL: https://svnweb.freebsd.org/changeset/base/306337 H> H> Log: H> In sendit(), if mp->msg_control is present, then in sockargs() we are allocating H> mbuf to store mp->msg_control. Later in kern_sendit(), call to getsock_cap(), H> will check validity of file pointer passed, if this fails EBADF is returned but H> mbuf allocated in sockargs() is not freed. Fix this possible leak. H> H> Submitted by: Lohith Bellad <lohith.bellad@me.com> H> Reviewed by: adrian H> MFC after: 3 weeks H> Differential Revision: https://reviews.freebsd.org/D7910 The commit appeared to be incorrect, but a problem exists. I'd like to look at it. Is there any reproduce recipe for the leak or bug filed? -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161004205352.GM23123>