Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 7 Apr 2018 17:36:53 +0000 (UTC)
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r332184 - stable/11/sys/netinet
Message-ID:  <201804071736.w37Harjb099136@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tuexen
Date: Sat Apr  7 17:36:53 2018
New Revision: 332184
URL: https://svnweb.freebsd.org/changeset/base/332184

Log:
  MFC r323374:
  
  Silence a Coverity warning from scanning the usrsctp library.

Modified:
  stable/11/sys/netinet/sctp_pcb.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/netinet/sctp_pcb.c
==============================================================================
--- stable/11/sys/netinet/sctp_pcb.c	Sat Apr  7 17:35:04 2018	(r332183)
+++ stable/11/sys/netinet/sctp_pcb.c	Sat Apr  7 17:36:53 2018	(r332184)
@@ -2919,9 +2919,9 @@ sctp_inpcb_bind(struct socket *so, struct sockaddr *ad
 		 */
 		/* got to be root to get at low ports */
 		if (ntohs(lport) < IPPORT_RESERVED) {
-			if (p && (error =
+			if ((p != NULL) && ((error =
 			    priv_check(p, PRIV_NETINET_RESERVEDPORT)
-			    )) {
+			    ) != 0)) {
 				SCTP_INP_DECR_REF(inp);
 				SCTP_INP_WUNLOCK(inp);
 				SCTP_INP_INFO_WUNLOCK();



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804071736.w37Harjb099136>