Date: Mon, 12 Apr 1999 23:35:27 -0700 (PDT) From: toh@victoria.tc.ca To: freebsd-gnats-submit@freebsd.org Subject: kern/11109: ipfw.ko Makefile contains CFLAGS+= -DDIVERT when it probably means -DIPDIVERT Message-ID: <19990413063527.78FD714D3B@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 11109 >Category: kern >Synopsis: ipfw.ko Makefile contains CFLAGS+= -DDIVERT when it probably means -DIPDIVERT >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Apr 12 23:40:00 PDT 1999 >Closed-Date: >Last-Modified: >Originator: Marc Sira >Release: 3.1-RELEASE >Organization: >Environment: FreeBSD tempo 3.1-RELEASE...i386 >Description: The ipfw.ko module in 3.1-RELEASE doesn't include support for divert sockets, which prevents it being used with natd. The Makefile in /sys/modules/ipfw contains "CFLAGS+= -DDIVERT", but that macro doesn't exist in any source file. It seems likely that someone (peter) wanted to enable divert sockets (which is a good idea), and meant to type "CFLAGS+= -IPDIVERT" instead (since that macro is used in the appropriate #ifdefs within ipfw.c). Fixing this (and the compiled module in the distribution, obviously) will make it easier for people to do NAT without compiling a new kernel, possibly even from the GENERIC kernel. >How-To-Repeat: $ kldload ipfw IP packet filtering initialized, divert disabled, ... >Fix: sed 's/-DDIVERT/-DIPDIVERT/' Makefile >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990413063527.78FD714D3B>