Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 16 Dec 1995 04:47:00 +1100
From:      Bruce Evans <bde@zeta.org.au>
To:        CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, peter@freefall.freebsd.org
Subject:   Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c
Message-ID:  <199512151747.EAA24132@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>peter       95/12/14 19:36:29

>  Modified:    sys/ufs/ffs  ffs_alloc.c
>  Log:
>  Silence a harmless warning...

Please fix problems, not warnings.

Here the problem is that one allocation function returns daddr_t and the
other allocation returns ino_t, and daddr_t (which happens to be long)
is incompatible with ino_t (which happens to be u_long).  Everything,
including the recently restored bogus function pointer cast, happens
to work because daddr_t and ino_t happen to have the same size and there
are apparently no sign extension problems.

The correct fix is probably for all allocation functions to return a
common large enough type (u_long in this case, provided there are no
sign extension problems).

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199512151747.EAA24132>