Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 2 Mar 2013 01:57:22 +0100
From:      Attilio Rao <attilio@freebsd.org>
To:        Davide Italiano <davide@freebsd.org>
Cc:        svn-src-projects@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r247603 - projects/calloutng/sys/kern
Message-ID:  <CAJ-FndDOPfgM2uYpfd4Jc_f1NKd-2WdK-o59xsPwZdX5D7%2B2Pg@mail.gmail.com>
In-Reply-To: <201303020053.r220rG7x063488@svn.freebsd.org>
References:  <201303020053.r220rG7x063488@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 2, 2013 at 1:53 AM, Davide Italiano <davide@freebsd.org> wrote:
> Author: davide
> Date: Sat Mar  2 00:53:16 2013
> New Revision: 247603
> URL: http://svnweb.freebsd.org/changeset/base/247603
>
> Log:
>   Try to use a better type for 'cc_waiting' and 'cc_cancel' fields of
>   cc_exec structure. Their value has to be only 0 or 1 and this change
>   try to make this more evident.
>
>   Suggested by: attilio

Usually you may also use TRUE/FALSE, but in few places in the kernel
they are checked against 0 (==0 or != 0) so that would be fine. I just
wouldn't assing them directly 1 as I'm sure this is still the case
somewhere in your kern_timeout.c.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndDOPfgM2uYpfd4Jc_f1NKd-2WdK-o59xsPwZdX5D7%2B2Pg>