From owner-svn-src-projects@FreeBSD.ORG Sat Mar 2 00:57:23 2013 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 5ED9E67E; Sat, 2 Mar 2013 00:57:23 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-ie0-x230.google.com (mail-ie0-x230.google.com [IPv6:2607:f8b0:4001:c03::230]) by mx1.freebsd.org (Postfix) with ESMTP id 2368D1F7C; Sat, 2 Mar 2013 00:57:23 +0000 (UTC) Received: by mail-ie0-f176.google.com with SMTP id k13so4258295iea.21 for ; Fri, 01 Mar 2013 16:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=pZihT3cvB3aDlA8EpURwAq+d8CWrpNkl0nhT7WmCcM4=; b=dDhAfDDJnXxdRo+xJ6jUmoR7VjYp8hwqr9Uzf1Ezykq5KvvuWK0HOQKHrar0ahNAcJ VQf3yy9kouxVXCb9mzYbDyFHI5ElznA2VYSS5IrfcidUgWqq3WeKh6/udXgoY5GzH4Kf B4quuytWMsVulXWtkBooVC2m7hrdeSY0/nKpikPmq5mKHSlAE/7/A0WcvBkdLWpcnI4I RfNl/XBT9XCQmeJTt/X8UgEAKSgujMuro+CmvVRKoP8JRddNTiHw0vzmHMqnTcJpSVpv 2GZTJNl4DvE4WRhYarTfljkzm3ZqY5alJZp0y/W8inA6R3dv5ZeZUNCpOnPSRuRY5LsC x9aw== MIME-Version: 1.0 X-Received: by 10.43.45.195 with SMTP id ul3mr9014203icb.14.1362185842805; Fri, 01 Mar 2013 16:57:22 -0800 (PST) Sender: asmrookie@gmail.com Received: by 10.42.117.134 with HTTP; Fri, 1 Mar 2013 16:57:22 -0800 (PST) In-Reply-To: <201303020053.r220rG7x063488@svn.freebsd.org> References: <201303020053.r220rG7x063488@svn.freebsd.org> Date: Sat, 2 Mar 2013 01:57:22 +0100 X-Google-Sender-Auth: Ms0U8CgFLBd5P-Apkmtdzze97TQ Message-ID: Subject: Re: svn commit: r247603 - projects/calloutng/sys/kern From: Attilio Rao To: Davide Italiano Content-Type: text/plain; charset=UTF-8 Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Mar 2013 00:57:23 -0000 On Sat, Mar 2, 2013 at 1:53 AM, Davide Italiano wrote: > Author: davide > Date: Sat Mar 2 00:53:16 2013 > New Revision: 247603 > URL: http://svnweb.freebsd.org/changeset/base/247603 > > Log: > Try to use a better type for 'cc_waiting' and 'cc_cancel' fields of > cc_exec structure. Their value has to be only 0 or 1 and this change > try to make this more evident. > > Suggested by: attilio Usually you may also use TRUE/FALSE, but in few places in the kernel they are checked against 0 (==0 or != 0) so that would be fine. I just wouldn't assing them directly 1 as I'm sure this is still the case somewhere in your kern_timeout.c. Attilio -- Peace can only be achieved by understanding - A. Einstein