Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 19 Dec 2014 13:24:53 +0000 (UTC)
From:      "Andrey V. Elsukov" <ae@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r275939 - stable/9/usr.sbin/syslogd
Message-ID:  <201412191324.sBJDOroo044883@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ae
Date: Fri Dec 19 13:24:52 2014
New Revision: 275939
URL: https://svnweb.freebsd.org/changeset/base/275939

Log:
  MFC r275729:
    Increase the buffer size to keep the list of programm names when
    parsing programm specification. It is safe to not check out of bounds
    access, because !isprint(p[i]) check will stop reading, when '\0'
    character will be read from the input string.
  
  Sponsored by:	Yandex LLC

Modified:
  stable/9/usr.sbin/syslogd/syslogd.c
Directory Properties:
  stable/9/usr.sbin/syslogd/   (props changed)

Modified: stable/9/usr.sbin/syslogd/syslogd.c
==============================================================================
--- stable/9/usr.sbin/syslogd/syslogd.c	Fri Dec 19 13:22:02 2014	(r275938)
+++ stable/9/usr.sbin/syslogd/syslogd.c	Fri Dec 19 13:24:52 2014	(r275939)
@@ -1539,7 +1539,7 @@ init(int signo)
 	struct filed *f, *next, **nextp;
 	char *p;
 	char cline[LINE_MAX];
- 	char prog[NAME_MAX+1];
+ 	char prog[LINE_MAX];
 	char host[MAXHOSTNAMELEN];
 	char oldLocalHostName[MAXHOSTNAMELEN];
 	char hostMsg[2*MAXHOSTNAMELEN+40];
@@ -1661,7 +1661,7 @@ init(int signo)
 				(void)strlcpy(prog, "*", sizeof(prog));
 				continue;
 			}
-			for (i = 0; i < NAME_MAX; i++) {
+			for (i = 0; i < LINE_MAX - 1; i++) {
 				if (!isprint(p[i]) || isspace(p[i]))
 					break;
 				prog[i] = p[i];



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201412191324.sBJDOroo044883>