Date: Wed, 27 Jan 1999 21:43:21 -0500 (EST) From: Brian Feldman <green@unixhelp.org> To: Peter Jeremy <peter.jeremy@auss2.alcatel.com.au> Cc: current@FreeBSD.ORG Subject: Re: btokup() macro in sys/malloc.h Message-ID: <Pine.BSF.4.05.9901272141490.10509-100000@janus.syracuse.net> In-Reply-To: <99Jan28.131753est.40347@border.alcanet.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 28 Jan 1999, Peter Jeremy wrote: > Matthew Dillon <dillon@apollo.backplane.com> wrote: > >:> NEW > >:> > >:> #define btokup(addr) (&kmemusage[((caddr_t)(addr) - kmembase) >> PAGE_SHIFT]) > >: > >:The added parentheses don't make any difference, semantically. This > >:change probably wouldn't meet the criteria spelled out in style(9): > > > > Then style(9) needs to be updated, because we have to add parenthesis > > to be able to not get warnings with -Wall. > > I'll support that. The example given in style(9): > > a = b->c[0] + ~d == (e || f) || g && h ? i : j >> 1; > > should rate as an entry in the Obfuscated C competition rather than > an example of maintainable code. > > style(9) should emphasize legibility and maintainability, rather than > minimizing the number of extraneous (from the compiler's perspective) > parenthesis. The code you're writing has to be maintained for many years > - and the maintainers will not always have your in-depth expertise. > The code also forms a `reference implementation' for someone who wants > to do something similar. Here's another vote from someone who uses liberal parentheses! I think of it like this: it may be correct, but if I can't understand it after I've written it, what good is the code? Saving a few bytes isn't worth obfuscating code. Style(9) should /dons flame-retardant suit/ encourage usage of extra parens that make code more readable to humans. > > Peter > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > Brian Feldman _ __ ___ ___ ___ green@unixhelp.org _ __ ___ | _ ) __| \ http://www.freebsd.org/ _ __ ___ ____ | _ \__ \ |) | FreeBSD: The Power to Serve! _ __ ___ ____ _____ |___/___/___/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9901272141490.10509-100000>