From owner-freebsd-mips@FreeBSD.ORG  Mon May 17 14:46:27 2010
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3A70C106566C
	for <freebsd-mips@freebsd.org>; Mon, 17 May 2010 14:46:27 +0000 (UTC)
	(envelope-from juli@clockworksquid.com)
Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 1A7DF8FC13
	for <freebsd-mips@freebsd.org>; Mon, 17 May 2010 14:46:26 +0000 (UTC)
Received: by pwi9 with SMTP id 9so2953478pwi.13
	for <freebsd-mips@freebsd.org>; Mon, 17 May 2010 07:46:26 -0700 (PDT)
Received: by 10.141.109.21 with SMTP id l21mr3746077rvm.114.1274107136259; 
	Mon, 17 May 2010 07:38:56 -0700 (PDT)
MIME-Version: 1.0
Sender: juli@clockworksquid.com
Received: by 10.140.247.13 with HTTP; Mon, 17 May 2010 07:38:36 -0700 (PDT)
In-Reply-To: <AANLkTikjF2SUa5GomVRtus176hjKyUyPAeDF-p1kwCcO@mail.gmail.com>
References: <AANLkTikjF2SUa5GomVRtus176hjKyUyPAeDF-p1kwCcO@mail.gmail.com>
From: Juli Mallett <jmallett@FreeBSD.org>
Date: Mon, 17 May 2010 07:38:36 -0700
X-Google-Sender-Auth: nDQYBYjlE95UoWSxV7j3n-FhlDc
Message-ID: <AANLkTimRaZxdHyU58axCZDBVLBrbK4lHU7j2dd4TXRDp@mail.gmail.com>
To: "C. Jayachandran" <c.jayachandran@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-mips@freebsd.org
Subject: Re: Minor fixup for the MIPS SMP platform code.
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 May 2010 14:46:27 -0000

On Mon, May 17, 2010 at 07:33, C. Jayachandran <c.jayachandran@gmail.com> wrote:
> The attached patch (also at
> http://sites.google.com/site/cjayachandran/files) has two changes:
> - moves the intr masking code to platform_init_ap, so that we can avoid the
> #ifdef for XLR
> - adds a platform_smp_topo() function so that platforms can define their
> topology
>
> I've also attempted to fixup sys/mips/sibyte to reflect these changes, but
> it might need further work.
> sys/mips/cavium also might need similar changes for SMP.
>
> Please review and apply if the changes are okay.

They look good to me; there's what looks like a minor style bug in
hwfunc.h with the placement of the * in the platform topo function
definition, but that's pretty trivial.  I'll be glad to take care of
committing the Octeon fixes.  If Neel and Randall think it's good I
guess Randall can commit it?

Juli.