Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 9 Feb 2001 10:42:15 -0800
From:      Alfred Perlstein <bright@wintelcom.net>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern kern_exit.c
Message-ID:  <20010209104215.H26076@fw.wintelcom.net>
In-Reply-To: <200102091643.f19GhJK78520@freefall.freebsd.org>; from jhb@FreeBSD.org on Fri, Feb 09, 2001 at 08:43:18AM -0800
References:  <200102091643.f19GhJK78520@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* John Baldwin <jhb@FreeBSD.org> [010209 10:18] wrote:
> jhb         2001/02/09 08:43:18 PST
> 
>   Modified files:
>     sys/kern             kern_exit.c 
>   Log:
>   Release the proc lock around crfree() and uifree() in wait1().  It leads to
>   a lock order violation, and since p is already a zombie at this point,
>   I'm not sure that we even need all the locking currently in wait1().

My first question was:
  How does this lead to a lock order violation?

Then I realized it might be what happens if crfree/uifree call into
free() which in turn calls into Giant?

It'd be helpful to explain in more detail what you found and fixed
along with how and why.  I see everything but 'why' in detail and
if you want others to be able to get it right (or find a flaw in
your logic) you'll need to be more clear.

-- 
-Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org]
"I have the heart of a child; I keep it in a jar on my desk."


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010209104215.H26076>