Date: Wed, 13 Apr 2005 00:30:31 GMT
From: "Timur I. Bakeyev" <timur@gnu.org>
To: freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/79259: [PATCH] net/samba: WITHOUT_{ADS,CUPS} fix
Message-ID: <200504130030.j3D0UV65029135@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/79259; it has been noted by GNATS.
From: "Timur I. Bakeyev" <timur@gnu.org>
To: "Se?n C. Farley" <sean-freebsd@farley.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/79259: [PATCH] net/samba: WITHOUT_{ADS,CUPS} fix
Date: Wed, 13 Apr 2005 02:20:43 +0200
Hi Sean!
On Thu, Mar 31, 2005 at 06:59:21PM -0600, Se?n C. Farley wrote:
> On Thu, 31 Mar 2005, Timur I. Bakeyev wrote:
>
> I reversed the knobs to have it default to CUPS (current behavior) but
> accept the WITHOUT_CUPS flag to be able to override it. Defining
> WITH_CUPS is a noop since it was the default, therefore, it needs to
> look for WITHOUT_CUPS to be able to turn it off. The situation with
> WITHOUT_ADS is similar.
>
> cd /usr/ports/net/samba3
> make rmconfig
> make -DWITHOUT_CUPS -DBATCH
I've made changes like this:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net/samba3/Makefile,v
retrieving revision 1.139
diff -u -r1.139 Makefile
--- Makefile 12 Apr 2005 03:26:16 -0000 1.139
+++ Makefile 13 Apr 2005 00:17:14 -0000
@@ -93,7 +93,7 @@
CONFIGURE_ARGS+= --with-pam --with-readline --with-sendfile-support \
--without-libsmbclient --without-python
-.if defined(WITH_CUPS)
+.if !defined(WITHOUT_CUPS)
LIB_DEPENDS+= cups.2:${PORTSDIR}/print/cups-base
CONFIGURE_ARGS+= --enable-cups
CUPS= cups
@@ -216,7 +216,7 @@
.endif
# Common part
-.if defined(WITH_ADS)
+.if !defined(WITHOUT_ADS)
WANT_LDAP= yes
WANT_KRB5= yes
CONFIGURE_ARGS+= --with-ads
Together with:
.if defined(PACKAGE_BUILDING)
# Kerberos5 setup is very box specific, we don't
# want artificial dependencies in the packages
OPTIONS+= ADS "With Active Directory support" off
.else
OPTIONS+= ADS "With Active Directory support" on
.endif
I hope it'll give desired effect for you.
With best regards,
Timur.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200504130030.j3D0UV65029135>