From owner-freebsd-hackers Tue Oct 17 12: 6:18 2000 Delivered-To: freebsd-hackers@freebsd.org Received: from smtp04.primenet.com (smtp04.primenet.com [206.165.6.134]) by hub.freebsd.org (Postfix) with ESMTP id 40DF937B4CF; Tue, 17 Oct 2000 12:06:14 -0700 (PDT) Received: (from daemon@localhost) by smtp04.primenet.com (8.9.3/8.9.3) id MAA07087; Tue, 17 Oct 2000 12:03:14 -0700 (MST) Received: from usr05.primenet.com(206.165.6.205) via SMTP by smtp04.primenet.com, id smtpdAAAaoaGzn; Tue Oct 17 12:02:55 2000 Received: (from tlambert@localhost) by usr05.primenet.com (8.8.5/8.8.5) id MAA00326; Tue, 17 Oct 2000 12:05:43 -0700 (MST) From: Terry Lambert Message-Id: <200010171905.MAA00326@usr05.primenet.com> Subject: Re: Module parameters? (WildWire DSL card driver) To: peter@netplex.com.au (Peter Wemm) Date: Tue, 17 Oct 2000 19:05:42 +0000 (GMT) Cc: tlambert@primenet.com (Terry Lambert), bright@wintelcom.net (Alfred Perlstein), gcorcoran@lucent.com (Gary T. Corcoran), freebsd-hackers@FreeBSD.ORG, freebsd-net@FreeBSD.ORG In-Reply-To: <200010170712.e9H7C3G58805@netplex.com.au> from "Peter Wemm" at Oct 17, 2000 12:12:03 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > I guess I'm asking "What moron would want to intentionally disable > > system resource tracking?". > > Who said anything about disabling system resource tracking? "track all > closes" means to call the devsw d_close function for *each* close, not just > for the "last close" as 99% of our drivers expect... If we suddenly caused > d_close() to be called on every close() syscall, then existing drivers break > because they are used to freeing everything and cleaning up when the close > function is called. Who remembers the open that resulted in the close, if not the driver? Perhaps I'm merely complaining that there are not seperate "close" and "last_close" entry points, since exposing a "last_close" entry point, and then a generic "close" handler that calls "last_close" when the reference count goes from 1->0, which is ignored if the driver has a non-generic handler. Not much of a namespace exposure kludge. I guess I'm anout as annoyed as I was when supposed "bit rot" killed the ISODE and X.25 functioning, when certain kernel interfaces were redefined, without the person doing the redefintion taking care to maintain all caller instances, or when a similar thing ate LFS. 8-(. Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message