Date: Mon, 23 Oct 1995 04:05:03 -0700 From: David Greenman <davidg@Root.COM> To: Peter Wemm <peter@jhome.dialix.com> Cc: CVS-commiters@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.sbin/config mkmakefile.c Message-ID: <199510231105.EAA01432@corbin.Root.COM> In-Reply-To: Your message of "Mon, 23 Oct 95 18:55:01 %2B0800." <Pine.BSF.3.91.951023185233.5332N-100000@jhome.DIALix.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
>On Mon, 23 Oct 1995, David Greenman wrote: >> >> davidg 95/10/23 03:29:17 >> >> Modified: usr.sbin/config mkmakefile.c >> Log: >> Don't pre-processor define 'ident'. This has subtle consequences for people >> who don't carefully consider their choice for the machine name. The same >> functionality can still be had with an "option", so nothing is lost. > >I saw a couple of >#ifdef GENERIC /* compiling for generic kernel */ >.... >#endif >around the place some time ago. Are these gone too? The only place that they existed was in the swap partition code, and that stuff was revamped long ago. So yes, these are gone, too. >If this functionality is needed, perhaps it'd be better to change it to >CONFIG_<ident> instead? ie: #ifdef CONFIG_GENERIC instead? I don't think so. I really would rather not have the machine ident be defined. In my opinion, it's extremely poor form to depend on one of these in any case. -DG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199510231105.EAA01432>