From owner-freebsd-commit  Mon Oct 23 04:06:16 1995
Return-Path: owner-commit
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id EAA03537
          for freebsd-commit-outgoing; Mon, 23 Oct 1995 04:06:16 -0700
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id EAA03519
          for cvs-all-outgoing; Mon, 23 Oct 1995 04:06:07 -0700
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id EAA03509
          for cvs-usrsbin-outgoing; Mon, 23 Oct 1995 04:06:05 -0700
Received: from Root.COM (implode.Root.COM [198.145.90.17])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id EAA03501
          ; Mon, 23 Oct 1995 04:05:52 -0700
Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id EAA03537; Mon, 23 Oct 1995 04:05:31 -0700
Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id EAA01432; Mon, 23 Oct 1995 04:05:07 -0700
Message-Id: <199510231105.EAA01432@corbin.Root.COM>
To: Peter Wemm <peter@jhome.dialix.com>
cc: CVS-commiters@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org
Subject: Re: cvs commit: src/usr.sbin/config mkmakefile.c 
In-reply-to: Your message of "Mon, 23 Oct 95 18:55:01 +0800."
             <Pine.BSF.3.91.951023185233.5332N-100000@jhome.DIALix.COM> 
From: David Greenman <davidg@Root.COM>
Reply-To: davidg@Root.COM
Date: Mon, 23 Oct 1995 04:05:03 -0700
Sender: owner-commit@FreeBSD.org
Precedence: bulk

>On Mon, 23 Oct 1995, David Greenman wrote:
>> 
>> davidg      95/10/23 03:29:17
>> 
>>   Modified:    usr.sbin/config  mkmakefile.c
>>   Log:
>>   Don't pre-processor define 'ident'. This has subtle consequences for people
>>   who don't carefully consider their choice for the machine name. The same
>>   functionality can still be had with an "option", so nothing is lost.
>
>I saw a couple of
>#ifdef GENERIC /* compiling for generic kernel */
>....
>#endif
>around the place some time ago.  Are these gone too?

   The only place that they existed was in the swap partition code, and that
stuff was revamped long ago. So yes, these are gone, too.

>If this functionality is needed, perhaps it'd be better to change it to 
>CONFIG_<ident> instead?  ie: #ifdef CONFIG_GENERIC instead?

   I don't think so. I really would rather not have the machine ident be
defined. In my opinion, it's extremely poor form to depend on one of these
in any case.

-DG