Date: Sun, 30 Sep 2007 13:15:49 +0200 (CEST) From: Ulrich Spoerlein <uspoerlein@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Cc: moggie@elasticmind.net, shaun@FreeBSD.org Subject: ports/116761: [PATCH] irc/ratbox-services: Unbreak and portlint Message-ID: <200709301115.l8UBFn5Y076408@coyote.spoerlein.net> Resent-Message-ID: <200709301150.l8UBo1BK066042@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 116761
>Category: ports
>Synopsis: [PATCH] irc/ratbox-services: Unbreak and portlint
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Sep 30 11:50:00 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator: Ulrich Spoerlein
>Release: FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
>Description:
Hi,
the port has a syntax error which breaks (INDEX) building if WITH_PGSQL is set.
I also took the liberty of removing some portlint warnings.
Port maintainer (moggie@elasticmind.net) is cc'd.
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
% make -DWITH_PGSQL describe -C /usr/ports/irc/ratbox-services
"Makefile", line 120: Need an operator
make: fatal errors encountered -- cannot continue
>Fix:
--- ratbox-services-1.1.2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/irc/ratbox-services/Makefile,v
retrieving revision 1.4
diff -u -p -u -r1.4 Makefile
--- Makefile 28 Sep 2007 13:07:29 -0000 1.4
+++ Makefile 30 Sep 2007 11:11:11 -0000
@@ -97,7 +97,7 @@ CONFIGURE_ARGS+= --disable-banserv
.endif
.if defined(WITHOUT_WATCHSERV)
-CONFIGURE_ARGS+= --disable-watchserv
+CONFIGURE_ARGS+= --disable-watchserv
.endif
.if !defined(WITH_SQLITE) && !defined(WITH_PGSQL)
@@ -106,19 +106,19 @@ IGNORE= requires either an sqlite or p
.if defined(WITH_SQLITE)
USE_SQLITE= 3
-CONFIGURE_ARGS+= --enable-sqlite3=${LOCALBASE}
+CONFIGURE_ARGS+= --enable-sqlite3=${LOCALBASE}
.endif
# This ratbox-services version has known problems when integrating
# with MySQL and should be avoided until it is fixed in version 1.1.3
#.if defined(WITH_MYSQL)
-#USE_MYSQL
+#USE_MYSQL= yes
#CONFIGURE_ARGS+= --enable-mysql=${LOCALBASE}
#.endif
.if defined(WITH_PGSQL)
-USE_PGSQL
-CONFIGURE_ARGS+= --enable-pgsql=${LOCALBASE}
+USE_PGSQL= yes
+CONFIGURE_ARGS+= --enable-pgsql=${LOCALBASE}
.endif
#-- User Configuration -------------------------------------------------
@@ -132,7 +132,7 @@ CONFIGURE_ARGS+= --with-topiclen=${TOPIC
.endif
.if defined(USERREGLEN)
-CONFIGURE_ARGS+= --with-userreglen=${USERREGLEN}
+CONFIGURE_ARGS+= --with-userreglen=${USERREGLEN}
.endif
#-----------------------------------------------------------------------
Index: pkg-plist
===================================================================
RCS file: /home/ncvs/ports/irc/ratbox-services/pkg-plist,v
retrieving revision 1.2
diff -u -p -u -r1.2 pkg-plist
--- pkg-plist 28 Sep 2007 01:03:39 -0000 1.2
+++ pkg-plist 30 Sep 2007 11:12:15 -0000
@@ -203,4 +203,3 @@ include/client.h
@dirrmtry %%DOCSDIR%%
@unexec f="/var/log/ratbox-services.log"; if [ ! -s "$f" ]; then rm -f "$f"; fi
@unexec f="/var/run/ratbox-services.pid"; if [ ! -s "$f" ]; then rm -f "$f"; fi
-
--- ratbox-services-1.1.2.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200709301115.l8UBFn5Y076408>