From owner-freebsd-rc@FreeBSD.ORG Tue Jan 22 21:17:23 2013 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id C2CAF7E; Tue, 22 Jan 2013 21:17:23 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 374E53F8; Tue, 22 Jan 2013 21:17:23 +0000 (UTC) Received: from alph.allbsd.org (p1137-ipbf1505funabasi.chiba.ocn.ne.jp [118.7.212.137]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r0MLH13o046904 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Jan 2013 06:17:11 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id r0MLGxKC045591; Wed, 23 Jan 2013 06:17:00 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Wed, 23 Jan 2013 06:16:42 +0900 (JST) Message-Id: <20130123.061642.1790268617280808873.hrs@allbsd.org> To: utisoft@gmail.com Subject: Re: mountlate being too mount-happy From: Hiroki Sato In-Reply-To: References: <20121118.150935.240651183336258002.hrs@allbsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Wed_Jan_23_06_16_42_2013_392)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Wed, 23 Jan 2013 06:17:12 +0900 (JST) X-Spam-Status: No, score=-98.1 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: mjguzik@gmail.com, freebsd-rc@FreeBSD.org, mjg@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2013 21:17:23 -0000 ----Security_Multipart(Wed_Jan_23_06_16_42_2013_392)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Chris Rees wrote in : ut> [dragging it up again!] ut> ut> On 18 November 2012 14:28, Chris Rees wrote: ut> > On 18 November 2012 06:09, Hiroki Sato wrote: ut> >> Mateusz Guzik wrote ut> >> in <20121118002245.GB15055@dft-labs.eu>: ut> >> ut> >> mj> On Sun, Nov 18, 2012 at 07:43:25AM +0900, Hiroki Sato wrote: ut> >> mj> > Chris Rees wrote ut> >> mj> > in < ut> CADLo839wqzAPenuQDOVpQ74yjCMkPQNceKpvs_N9XNwMLrkC1A@mail.gmail.com>: ut> >> mj> > ut> >> mj> > ut> On 2 November 2012 14:21, Eitan Adler ut> wrote: ut> >> mj> > ut> > On 2 November 2012 09:56, Chris Rees ut> wrote: ut> >> mj> > ut> >> I'll take a look. ut> >> mj> > ut> > ut> >> mj> > ut> > untested: ut> >> mj> > ut> ut> >> mj> > ut> Based on Eitan's patch, I've tested this one, and documented ut> it in mount(8) too: ut> >> mj> > ut> ut> >> mj> > ut> http://www.bayofrum.net/~crees/patches/mountonlylate.diff ut> >> mj> > ut> ut> >> mj> > ut> Does anyone have any suggestions/objections/urge to approve it? ut> >> mj> > ut> >> mj> > Is the original problem due to backgrounding of NFS mount only? If ut> >> mj> > so, implementing prevention of duplicate invocation into mount(8) ut> >> mj> > would be more reasonable, I think. ut> >> mj> > ut> >> mj> ut> >> mj> We have 2 distinct scripts that try to mount same set of filesystems. ut> >> mj> I think this is the real bug here and proposed patches makes it go ut> away in ut> >> mj> an IMHO acceptable way. ut> >> ut> >> I just wanted to make sure if the case is limited to background NFS ut> >> mount or not. ut> >> ut> >> rc.d/mountlate just tries to mount the filesystems that are not ut> >> mounted yet at that time in addition to the "late" ones, not always ut> >> to mount the same set twice. If it is a bug, it is better to simply ut> >> fix -l to exclude not-yet-mounted ones without "late" keyword than ut> >> adding another option. ut> > ut> > I don't think it's a bug as such-- -l option is clearly labelled in ut> > the manpage (emphasis mine): ut> > ut> > When used in conjunction with the -a option, *also* mount those ut> > file systems which are marked as ``late''. ut> > ut> > I think that for POLA and to avoid changing behaviour of an option ut> > that's been there a long time we need the -L option. ut> > ut> > I disagree with Mateusz here-- split operations in rc makes two ut> > scripts necessary; mount and mountlate are two separate operations, ut> > done at different times. ut> ut> Hiroki-san, do you still believe that changing the behaviour of -l is the ut> correct way to go, rather than add a -L option for only late filesystems? ut> (mount -la currently mounts *all* filesystems, you suggested to change to ut> just late). ut> ut> I'd like to fix this, but I want to make sure you're happy with the ut> solution. Sorry for being unresponsive. Can you give me a couple of days to double-check the behavior? -- Hiroki ----Security_Multipart(Wed_Jan_23_06_16_42_2013_392)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlD/AbsACgkQTyzT2CeTzy3eRACg3+STWInQLkR8bknhs2aWFGaF 0WQAnA/1yu7rXqJI/afBoRMScXingrec =R41A -----END PGP SIGNATURE----- ----Security_Multipart(Wed_Jan_23_06_16_42_2013_392)----