Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 04 Jun 2013 00:18:29 +0200
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        sylvio@FreeBSD.org
Subject:   ports/179278: [PATCH] devel/p5-Goo-Canvas: Fix port, add license, add missing dependencies
Message-ID:  <20130603221833.63B28700@hub.freebsd.org>
Resent-Message-ID: <201306032220.r53MK2c3052810@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         179278
>Category:       ports
>Synopsis:       [PATCH] devel/p5-Goo-Canvas: Fix port, add license, add missing dependencies
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 03 22:20:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE-p3 amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE-p3 FreeBSD 9.1-RELEASE-p3 #0: Mon Apr 29 18:27:25 UTC 2013
>Description:

- Shorten header
- Fix port
- Add license
- Add dependencies for devel/p5-ExtUtils-Depends and devel/p5-ExtUtils-PkgConfig
- Trim pkg-plist

Port maintainer (sylvio@FreeBSD.org) is cc'd.

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)
>How-To-Repeat:

Build log

https://redports.org/buildarchive/20130603162000-65191/

>Fix:

--- p5-Goo-Canvas-0.06_2.patch begins here ---
diff -ruN /usr/ports/devel/p5-Goo-Canvas/Makefile ./Makefile
--- /usr/ports/devel/p5-Goo-Canvas/Makefile	2013-06-02 18:59:42.000000000 +0200
+++ ./Makefile	2013-06-03 18:01:42.000000000 +0200
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	p5-Goo-Canvas
-# Date created:		2010-03-10
-# Whom:			Sylvio Cesar Teixeira <sylvio@FreeBSD.org>
-#
+# Created by: Sylvio Cesar Teixeira <sylvio@FreeBSD.org>
 # $FreeBSD: head/devel/p5-Goo-Canvas/Makefile 317794 2013-05-10 13:21:32Z miwi $
-#
 
 PORTNAME=	Goo-Canvas
 PORTVERSION=	0.06
@@ -15,18 +11,21 @@
 MAINTAINER=	sylvio@FreeBSD.org
 COMMENT=	Perl interface to the GooCanvas
 
+LICENSE=	GPLv2
+
 BUILD_DEPENDS=	p5-Cairo>=0:${PORTSDIR}/graphics/p5-Cairo \
+		p5-ExtUtils-Depends>=0:${PORTSDIR}/devel/p5-ExtUtils-Depends \
+		p5-ExtUtils-PkgConfig>=1:${PORTSDIR}/devel/p5-ExtUtils-PkgConfig \
 		p5-Glib2>=0:${PORTSDIR}/devel/p5-Glib2 \
 		p5-Gtk2>=0:${PORTSDIR}/x11-toolkits/p5-Gtk2
-LIB_DEPENDS=	goocanvas.3:${PORTSDIR}/graphics/goocanvas \
-		gdk_pixbuf_xlib.2:${PORTSDIR}/graphics/gdk-pixbuf
+LIB_DEPENDS=	goocanvas:${PORTSDIR}/graphics/goocanvas
 RUN_DEPENDS=	p5-Cairo>=0:${PORTSDIR}/graphics/p5-Cairo \
 		p5-Glib2>=0:${PORTSDIR}/devel/p5-Glib2 \
 		p5-Gtk2>=0:${PORTSDIR}/x11-toolkits/p5-Gtk2
 
-MAKE_JOBS_UNSAFE=	yes
+USE_GNOME=	gdkpixbuf
 
-BROKEN=		fails to build
+MAKE_JOBS_UNSAFE=	yes
 
 MAN1=		perltetris.pl.1 perlmine.pl.1
 MAN3=		Goo::Canvas::Item.3 \
diff -ruN /usr/ports/devel/p5-Goo-Canvas/pkg-descr ./pkg-descr
--- /usr/ports/devel/p5-Goo-Canvas/pkg-descr	2013-06-02 18:59:42.000000000 +0200
+++ ./pkg-descr	2013-04-05 01:09:36.000000000 +0200
@@ -1,3 +1,3 @@
 Perl interface to the GooCanvas
 
-WWW:	http://search.cpan.org/dist/Goo-Canvas/
+WWW: http://search.cpan.org/dist/Goo-Canvas/
diff -ruN /usr/ports/devel/p5-Goo-Canvas/pkg-plist ./pkg-plist
--- /usr/ports/devel/p5-Goo-Canvas/pkg-plist	2013-06-02 18:59:42.000000000 +0200
+++ ./pkg-plist	2013-06-03 18:17:17.000000000 +0200
@@ -38,9 +38,9 @@
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Goo/Canvas/.packlist
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Goo/Canvas/Canvas.bs
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Goo/Canvas/Canvas.so
-@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Goo/Canvas
+@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Goo/Canvas
 @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Goo
 @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Goo/Cairo
-@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Goo/Canvas/Install
-@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Goo/Canvas
+@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/Goo/Canvas/Install
+@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/Goo/Canvas
 @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Goo
--- p5-Goo-Canvas-0.06_2.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130603221833.63B28700>