From owner-freebsd-current@FreeBSD.ORG  Sat Jan 14 14:44:47 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B34F2106566B;
	Sat, 14 Jan 2012 14:44:47 +0000 (UTC) (envelope-from jilles@stack.nl)
Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107])
	by mx1.freebsd.org (Postfix) with ESMTP id 0045C8FC0C;
	Sat, 14 Jan 2012 14:44:46 +0000 (UTC)
Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131])
	by mx1.stack.nl (Postfix) with ESMTP id CB9491E018E;
	Sat, 14 Jan 2012 15:44:45 +0100 (CET)
Received: by snail.stack.nl (Postfix, from userid 1677)
	id B206A28468; Sat, 14 Jan 2012 15:44:45 +0100 (CET)
Date: Sat, 14 Jan 2012 15:44:45 +0100
From: Jilles Tjoelker <jilles@stack.nl>
To: Doug Barton <dougb@FreeBSD.org>
Message-ID: <20120114144445.GA53777@stack.nl>
References: <4F114577.30201@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F114577.30201@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-current <freebsd-current@FreeBSD.org>
Subject: Re: HEADS UP: set_rcvar() removed from rc.subr
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jan 2012 14:44:47 -0000

On Sat, Jan 14, 2012 at 01:05:59AM -0800, Doug Barton wrote:
> Per discussion in freebsd-rc@, I have removed set_rcvar() from rc.subr.
> The concept of set_rcvar() was nice in theory, but the forks it creates
> are a drag on the startup process, which is especially noticeable on
> slower systems, such as embedded ones.

> I have no plans to MFC this change, so it should only affect users who
> are actually on 10-current. If you have scripts in /usr/local/etc/rc.d
> (which if you have ports installed you almost certainly do) ...

> to make the change by hand, change this:

> name=foo
> rcvar=`set_rcvar`

> to:

> name=foo
> rcvar=foo_enable

> I didn't bump PORTREVISIONs because the change only applies to HEAD. But
> all of the ports are updated, so if you can't figure out how to make the
> change, just reinstall it.

Why must the 2-argument form of set_rcvar die at the same time? It is
used very differently and does not cause unnecessary forks. Instead, it
is called in the same shell environment to define additional rc.conf
variables that have defaults and are shown in '<script> rcvar'.

-- 
Jilles Tjoelker