Date: Wed, 25 Mar 2015 10:10:32 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 198895] net-mgmt/smokeping: hardcoded pidfile Message-ID: <bug-198895-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198895 Bug ID: 198895 Summary: net-mgmt/smokeping: hardcoded pidfile Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: rodrigo@FreeBSD.org Reporter: buchtajz@borsice.net Assignee: rodrigo@FreeBSD.org Flags: maintainer-feedback?(rodrigo@FreeBSD.org) The comment in startup script is not completely true. Smokeping pidfile is configurable via piddir variable in smokeping config. So, when someone change this, the script will not work. /usr/local/etc/rc.d/smokeping : # pidfile is hardcoded in Smokeping.pm, not configurable smokeping_pidfile="/storage/smokeping/pid" /usr/local/etc/smokeping/config : piddir = /any/dir/for/pidfile Instead hardcoded smokeping_pidfile variable, maybe better using : ${smokeping_pidfile="%%PREFIX%%/var/smokeping/pid"} or using "smokeping variable" : ${smokeping_piddir="%%PREFIX%%/var/smokeping"} smokeping_pidfile="${smokeping_piddir}/pid" Regards buchtajz -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-198895-13>