Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 9 Oct 2013 03:19:39 GMT
From:      clutton <clutton@zoho.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/182848: [maintainer update] [stagedir] multimedia/ffmpegthumbnailer
Message-ID:  <201310090319.r993Jdtx053114@oldred.freebsd.org>
Resent-Message-ID: <201310090320.r993K0nV091312@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         182848
>Category:       ports
>Synopsis:       [maintainer update] [stagedir] multimedia/ffmpegthumbnailer
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 09 03:20:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     clutton
>Release:        current
>Organization:
>Environment:
FreeBSD host02 10.0-ALPHA4 FreeBSD 10.0-ALPHA4 #0 716c203(master): Sun Oct  6 11:46:04 EEST 2013     user@host02:/tmp/usr/src/sys/HOST02  amd64

>Description:
I want to update my maintainer email (the old one is broken).
And I have a question: 

I've deleted the line
-	cd ${WRKSRC}/ && ${SETENV} ${MAKE_ENV} ${MAKE} install-pkgconfigDATA
was it correct?
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff --git a/multimedia/ffmpegthumbnailer/Makefile b/multimedia/ffmpegthumbnailer/Makefile
index ebc9e6e..defd2ff 100644
--- a/multimedia/ffmpegthumbnailer/Makefile
+++ b/multimedia/ffmpegthumbnailer/Makefile
@@ -7,7 +7,7 @@ PORTREVISION=	2
 CATEGORIES=	multimedia graphics
 MASTER_SITES=	GOOGLE_CODE
 
-MAINTAINER=	mbsd@isgroup.com.ua
+MAINTAINER=	clutton@zoho.com
 COMMENT=	Lightweight video thumbnailer that can be used by file managers
 
 LIB_DEPENDS=	png15:${PORTSDIR}/graphics/png \
@@ -25,24 +25,19 @@ USE_LDCONFIG=	yes
 
 OPTIONS_DEFINE=	GNOME
 
-MAN1=		ffmpegthumbnailer.1
-
-NO_STAGE=	yes
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MGNOME}
-PKGNAMESUFFIX+=	-gnome
 USE_GNOME+=	gconf2
 GCONF_SCHEMAS=	ffmpegthumbnailer.schemas
 .endif
 
 post-install:
-	cd ${WRKSRC}/ && ${SETENV} ${MAKE_ENV} ${MAKE} install-pkgconfigDATA
 .if ${PORT_OPTIONS:MGNOME}
-	${MKDIR} ${PREFIX}/etc/gconf/schemas
-	${INSTALL_DATA} ${FILESDIR}/${GCONF_SCHEMAS} ${PREFIX}/etc/gconf/schemas
-	@${SETENV} GCONF_CONFIG_SOURCE=xml:${GCONF_CONFIG_OPTIONS}:${PREFIX}/${GCONF_CONFIG_DIRECTORY} \
-		gconftool-2 --makefile-install-rule ${PREFIX}/etc/gconf/schemas/${GCONF_SCHEMAS} \
+	${MKDIR} ${STAGEDIR}${PREFIX}/etc/gconf/schemas
+	${INSTALL_DATA} ${FILESDIR}/${GCONF_SCHEMAS} ${STAGEDIR}${PREFIX}/etc/gconf/schemas
+	@${SETENV} GCONF_CONFIG_SOURCE=xml:${GCONF_CONFIG_OPTIONS}:${STAGEDIR}${PREFIX}/${GCONF_CONFIG_DIRECTORY} \
+		gconftool-2 --makefile-install-rule ${STAGEDIR}${PREFIX}/etc/gconf/schemas/${GCONF_SCHEMAS} \
 		> /dev/null || ${TRUE}
 .endif
 
diff --git a/multimedia/ffmpegthumbnailer/pkg-plist b/multimedia/ffmpegthumbnailer/pkg-plist
index 7f8e8fb..24769d6 100644
--- a/multimedia/ffmpegthumbnailer/pkg-plist
+++ b/multimedia/ffmpegthumbnailer/pkg-plist
@@ -10,4 +10,6 @@ lib/libffmpegthumbnailer.la
 lib/libffmpegthumbnailer.so
 lib/libffmpegthumbnailer.so.4
 libdata/pkgconfig/libffmpegthumbnailer.pc
+man/man1/ffmpegthumbnailer.1.gz
+
 @dirrm include/libffmpegthumbnailer


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310090319.r993Jdtx053114>