From owner-cvs-all@FreeBSD.ORG  Thu Jul 26 13:03:21 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 54D4416A419;
	Thu, 26 Jul 2007 13:03:21 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 3EEDC13C45E;
	Thu, 26 Jul 2007 13:03:21 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from rot26.obsecurity.org (elvis.mu.org [192.203.228.196])
	by elvis.mu.org (Postfix) with ESMTP id D31A11A4D7C;
	Thu, 26 Jul 2007 06:03:20 -0700 (PDT)
Received: by rot26.obsecurity.org (Postfix, from userid 1001)
	id 3A686BAB1; Thu, 26 Jul 2007 09:03:20 -0400 (EDT)
Date: Thu, 26 Jul 2007 09:03:20 -0400
From: Kris Kennaway <kris@obsecurity.org>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20070726130319.GA24271@rot26.obsecurity.org>
References: <200707031831.l63IVmfk001694@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200707031831.l63IVmfk001694@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/nfsclient nfs_subs.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jul 2007 13:03:21 -0000

On Tue, Jul 03, 2007 at 06:31:48PM +0000, John Baldwin wrote:
> jhb         2007-07-03 18:31:48 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/nfsclient        nfs_subs.c 
>   Log:
>   Fix for a race where out of order loading of NFS attrs into the
>   nfsnode could lead to attrs being stale. One example (that we
>   ran into) was a READDIR+, WRITE. The responses came back in
>   order, but the attrs from the WRITE were loaded before the
>   attrs from the READDIR+, leading to the wrong size from being
>   read on the next stat() call.
>   
>   MFC after:      1 week
>   Submitted by:   mohans
>   Approved by:    re (kensmith)

Cool, I think this is (one of?) the attr bugs I have also been seeing
for a long time.

Kris