Date: Thu, 4 Aug 2011 22:47:48 -0400 From: "b. f." <bf1783@googlemail.com> To: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: cvs-ports@freebsd.org, ports-committers@freebsd.org, cvs-all@freebsd.org, Brendan Fabeny <bf@freebsd.org> Subject: Re: cvs commit: ports/www/youtube_dl Makefile distinfo Message-ID: <CAGFTUwOQFJxX7_CJHGKutA15Y=%2BnGvBPG8w_fXeQ16seBG%2B8jw@mail.gmail.com> In-Reply-To: <20110805021028.GD12696@bonjour.sunpoet.net> References: <201108042336.p74NaqwG020915@repoman.freebsd.org> <20110805021028.GD12696@bonjour.sunpoet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/4/11, Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> wrote:
> On Thu, Aug 04, 2011 at 11:36:52PM +0000, Brendan Fabeny wrote:
>> bf 2011-08-04 23:36:52 UTC
>>
>> FreeBSD ports repository
>>
>> Modified files:
>> www/youtube_dl Makefile distinfo
>> Log:
>> update to 2011-08-04
>>
>> Approved by: araujo
>>
>> Revision Changes Path
>> 1.58 +3 -3 ports/www/youtube_dl/Makefile
>> 1.48 +2 -2 ports/www/youtube_dl/distinfo
>
> Hi,
>
> I noticed that you change ${DISTDIR}/${DIST_SUBDIR} to ${_DISTDIR}.
> IMHO, it would be better not to use _foo variables as they are named for
> internal use.
> Thanks.
Yes, that seems to be the convention. But it is a rather pedantic
objection to level in this case, where the variable is more of an
abbreviation, than a variable strictly internal to bsd.port.mk whose
value or role is likely to be changed. Are you aware of any plans to
do so?
In any event, I'll revert that part of the change.
b.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGFTUwOQFJxX7_CJHGKutA15Y=%2BnGvBPG8w_fXeQ16seBG%2B8jw>