From owner-freebsd-ports@FreeBSD.ORG Mon Jun 21 11:39:24 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F15F16A4CE; Mon, 21 Jun 2004 11:39:24 +0000 (GMT) Received: from infidel.fajita.org (oldhallfarm.demon.co.uk [80.176.128.55]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4904843D48; Mon, 21 Jun 2004 11:39:21 +0000 (GMT) (envelope-from lewiz@fajita.org) Received: from majic.fajita.org (majic.fajita.org [192.168.0.4]) by infidel.fajita.org (8.12.10/8.12.10) with ESMTP id i5LBdbY5085289; Mon, 21 Jun 2004 12:39:38 +0100 (BST) (envelope-from lewiz@fajita.org) Received: (from lewiz@localhost) by majic.fajita.org (8.12.10/8.12.10/Submit) id i5LBdbNC085288; Mon, 21 Jun 2004 12:39:37 +0100 (BST) (envelope-from lewiz) Date: Mon, 21 Jun 2004 12:39:37 +0100 From: Lewis Thompson To: Volker Stolz Message-ID: <20040621113937.GA83826@fajita.org> References: <20040620232712.GA75329@fajita.org> <200406202328.06979.mistry.7@osu.edu> <20040621070848.GA78206@i2.informatik.rwth-aachen.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pf9I7BMVVzbSWLtt" Content-Disposition: inline In-Reply-To: <20040621070848.GA78206@i2.informatik.rwth-aachen.de> X-GPG-Fingerprint: 90A4 939E 3847 A3E4 8103 2A48 22DA B428 542F ED3F X-GPG-Info: http://www.lewiz.org/~lewiz/pgpkey / horowitz.surfnet.nl User-Agent: Mutt/1.5.6i X-MailScanner-Information: Please contact the ISP for more information X-MailScanner: Found to be clean X-MailScanner-From: lewiz@fajita.org cc: Anish Mistry cc: ports@freebsd.org cc: lars.eggert@gmx.net Subject: Re: Freevo port (TESTING REQUIRED). X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2004 11:39:24 -0000 --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 21, 2004 at 09:08:48AM +0200, Volker Stolz wrote: > In local.freebsd-ports, you wrote: > >> I've been working on a port of Freevo (http://freevo.sf.net/), which is > >> ``an open-source home theatre PC platform'', for a while now and > >> hopefully within a week or two version 1.5.0 will be released. >=20 > Lewis' submission looks more complete to me. I'd say go ahead and send-pr. > Please fix some of the deficiencies reported by portlint before, most not= ably: >=20 > 1) > WARN: /usr/tmp/freevo/pkg-plist: Both ``%%PORTDOCS%%@dirrm %%DOCSDIR%%'' = and ``%%PORTDOCS%%@unexec %D/%%DOCSDIR%% 2>/dev/null || true'' are missing.= At least one should be used. > FATAL: Makefile: PORTVERSION looks illegal. You should modify "1.5.0rc3". Hmm, I must admit I completely forgot to run it past portlint (although I was aware that 1.5.0rc3 was an invalid PORTVERSION). I wouldn't have spotted the other WARN though, I've only used it minimally before and I have to run with --help to figure out the extra options! Thanks for that! > 3) > I don't understand your WITH-handling: >=20 > .if !defined(WITH_MPLAYER) > WITH_MPLAYER=3D yes > .endif Well, it seemed to me that if WITH_MPLAYER=3D0 was specified to make then WITH_MPLAYER was defined. However, if no option was defined then I want to install mplayer -- this seemed a nice way to do it at the time. Have I missed the plot here? Thanks for the info, -lewiz. --=20 I was so much older then, I'm younger than that now. --Bob Dylan, 1964. ------------------------------------------------------------------------ -| msn:purple@lewiz.net | jabber:lewiz@jabber.org | url:www.lewiz.org |- --pf9I7BMVVzbSWLtt Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFA1sj5Itq0KFQv7T8RAh5wAKD5oF1/OKPPjs4p4Ioz5cK33G0MfgCfa2oh KETB5paIjRfMps/jjdebMsE= =W1kd -----END PGP SIGNATURE----- --pf9I7BMVVzbSWLtt--