Date: Fri, 06 Feb 2009 11:21:41 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org>, ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/mail/dkim-milter/files milter-dkim.sh.in Message-ID: <498C8DC5.2080709@FreeBSD.org> In-Reply-To: <20090206122613.GB2720@kyuzo.dunkelkammer.void> References: <200902050840.n158eurh096951@repoman.freebsd.org> <498B64FE.9080101@FreeBSD.org> <20090206122613.GB2720@kyuzo.dunkelkammer.void>
next in thread | previous in thread | raw e-mail | index | archive | help
Stefan Walter wrote:
> Doug Barton, 05.02.09, 23:15h CET:
>
>> The milterdkim_flags default assignment is still wrong, it should be
>> done as the _alg default is done above it. Also, it's not necessary to
>> set empty defaults for anything except the _enable option. By default
>> rc.d handles empty variables appropriately.
>
> Hm...it seems like yesterday was one of those days when I shouldn't have
> committed anything...
>
> Thanks for the hint, I'll fix it as soon as I get to it.
No worries. The current version isn't "bad," just needlessly complicated.
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?498C8DC5.2080709>