Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 Feb 2012 16:16:16 +0400
From:      Andrey Zonov <andrey@zonov.org>
To:        Mikolaj Golub <trociny@freebsd.org>
Cc:        svn-src-head@FreeBSD.org, Guy Helmer <ghelmer@palisadesystems.com>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>
Subject:   Re: svn commit: r230869 - head/usr.sbin/daemon
Message-ID:  <4F365C10.5050607@zonov.org>
In-Reply-To: <86sjihsln4.fsf@kopusha.home.net>
References:  <27A0A960-F767-4D2C-BF3E-31F73FBF4E28@palisadesystems.com> <86zkcy5ur9.fsf@kopusha.home.net> <20120205093938.GC30033@garage.freebsd.pl> <86lioh7yz5.fsf@kopusha.home.net> <20120205214647.GI30033@garage.freebsd.pl> <86sjiov29o.fsf@in138.ua3> <20120206082706.GA1324@garage.freebsd.pl> <86wr7zmy8f.fsf@kopusha.home.net> <20120206221742.GA1336@garage.freebsd.pl> <86liodu3me.fsf@in138.ua3> <20120208090600.GA1308@garage.freebsd.pl> <86sjihsln4.fsf@kopusha.home.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On 11.02.2012 14:35, Mikolaj Golub wrote:
>
> Thank you. Here are the patches I would like to commit if there are no
> objections or other suggestions:
>
> http://people.freebsd.org/~trociny/daemon/daemon.spawn.1.patch
> http://people.freebsd.org/~trociny/daemon/daemon.SIGTERM.1.patch
> http://people.freebsd.org/~trociny/daemon/daemon.restart.1.patch
>

There are two more suggestions, if you don't mind.

Use madvise(MADV_PROTECT).  It would be useful because of the daemon(8) 
should not leak or eats much memory.

Check return code from pidfile_write() function.  I saw many times when 
pid could not be written because of there is not enough free space (but 
file was created).  Unfortunately, I have no suggestions how to handle 
this properly.

-- 
Andrey Zonov



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F365C10.5050607>