From owner-svn-src-head@FreeBSD.ORG  Sat Feb 11 12:16:23 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9407D106564A;
	Sat, 11 Feb 2012 12:16:23 +0000 (UTC)
	(envelope-from andrey@zonov.org)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id F09228FC17;
	Sat, 11 Feb 2012 12:16:21 +0000 (UTC)
Received: by bkcjg1 with SMTP id jg1so3175415bkc.13
	for <multiple recipients>; Sat, 11 Feb 2012 04:16:21 -0800 (PST)
Received: by 10.204.133.219 with SMTP id g27mr4086642bkt.47.1328962580613;
	Sat, 11 Feb 2012 04:16:20 -0800 (PST)
Received: from [10.254.254.77] (ppp95-165-138-46.pppoe.spdop.ru.
	[95.165.138.46])
	by mx.google.com with ESMTPS id cg2sm26572991bkb.12.2012.02.11.04.16.18
	(version=SSLv3 cipher=OTHER); Sat, 11 Feb 2012 04:16:19 -0800 (PST)
Message-ID: <4F365C10.5050607@zonov.org>
Date: Sat, 11 Feb 2012 16:16:16 +0400
From: Andrey Zonov <andrey@zonov.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ru;
	rv:1.8.1.24) Gecko/20100228 Thunderbird/2.0.0.24 Mnenhy/0.7.6.0
MIME-Version: 1.0
To: Mikolaj Golub <trociny@freebsd.org>
References: <27A0A960-F767-4D2C-BF3E-31F73FBF4E28@palisadesystems.com>
	<86zkcy5ur9.fsf@kopusha.home.net>
	<20120205093938.GC30033@garage.freebsd.pl>
	<86lioh7yz5.fsf@kopusha.home.net>
	<20120205214647.GI30033@garage.freebsd.pl>
	<86sjiov29o.fsf@in138.ua3>
	<20120206082706.GA1324@garage.freebsd.pl>
	<86wr7zmy8f.fsf@kopusha.home.net>
	<20120206221742.GA1336@garage.freebsd.pl>
	<86liodu3me.fsf@in138.ua3>
	<20120208090600.GA1308@garage.freebsd.pl>
	<86sjihsln4.fsf@kopusha.home.net>
In-Reply-To: <86sjihsln4.fsf@kopusha.home.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Gm-Message-State: ALoCoQmjkqkIuqoUexHDY0ur6TVcdRP1OJ1Pu+5O3Ea83Keh9e8ddwR+SS+CWo0w0Mal3kXhHE21
Cc: svn-src-head@FreeBSD.org, Guy Helmer <ghelmer@palisadesystems.com>,
	svn-src-all@FreeBSD.org, src-committers@FreeBSD.org,
	Pawel Jakub Dawidek <pjd@FreeBSD.org>
Subject: Re: svn commit: r230869 - head/usr.sbin/daemon
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Feb 2012 12:16:23 -0000

On 11.02.2012 14:35, Mikolaj Golub wrote:
>
> Thank you. Here are the patches I would like to commit if there are no
> objections or other suggestions:
>
> http://people.freebsd.org/~trociny/daemon/daemon.spawn.1.patch
> http://people.freebsd.org/~trociny/daemon/daemon.SIGTERM.1.patch
> http://people.freebsd.org/~trociny/daemon/daemon.restart.1.patch
>

There are two more suggestions, if you don't mind.

Use madvise(MADV_PROTECT).  It would be useful because of the daemon(8) 
should not leak or eats much memory.

Check return code from pidfile_write() function.  I saw many times when 
pid could not be written because of there is not enough free space (but 
file was created).  Unfortunately, I have no suggestions how to handle 
this properly.

-- 
Andrey Zonov