From owner-freebsd-fs@FreeBSD.ORG Mon Sep 24 13:55:33 2012 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 843F1106566C; Mon, 24 Sep 2012 13:55:33 +0000 (UTC) (envelope-from prvs=1614b6a669=killing@multiplay.co.uk) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) by mx1.freebsd.org (Postfix) with ESMTP id E2D9A8FC08; Mon, 24 Sep 2012 13:55:32 +0000 (UTC) Received: from r2d2 ([188.220.16.49]) by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (MDaemon PRO v10.0.4) with ESMTP id md50000208211.msg; Mon, 24 Sep 2012 14:55:30 +0100 X-Spam-Processed: mail1.multiplay.co.uk, Mon, 24 Sep 2012 14:55:30 +0100 (not processed: message from trusted or authenticated source) X-MDRemoteIP: 188.220.16.49 X-Return-Path: prvs=1614b6a669=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk Message-ID: <0BCB8A9018D84321BF1EF8F821BB2447@multiplay.co.uk> From: "Steven Hartland" To: "Ollivier Robert" , , "Charles Sprickman" , References: <20120923195357.GO1454@garage.freebsd.pl><1735E492-3C3C-491A-82E2-884E976B4BC4@gid.co.uk><20120923222520.GS1454@garage.freebsd.pl><58743599-C986-4735-A588-AEFAAEE5766A@bway.net><6B400C472FB24A7C94EF1AFB0DF6ABF1@multiplay.co.uk> <20120924132030.GA79156@roberto-aw.eurocontrol.fr> Date: Mon, 24 Sep 2012 14:55:27 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: Subject: Re: ZFS TRIM support committed to HEAD. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2012 13:55:33 -0000 ----- Original Message ----- From: "Ollivier Robert" > According to Steven Hartland: >> We applied the patch to a 8.3-RELEASE based install with additional patches >> including patches to provide TRIM support for CAM da devices via SATA >> pass-through including full support for security and identify commands in >> camcontrol. >> >> If anyone would like those as we can provide. > > That would be indeed very nice. Our current patchset minus the zfstrim one can be found here:- http://blog.multiplay.co.uk/dropzone/freebsd/zfs-trim-patchset83.tbz Of course you'll also need pjd's zfs trim patch set. It expects to be extracted in /usr/src, where it will create a patches subdir. If you then put the zfs trim patch in the same dir and run ./patches/apply.sh you should be good. There's a fare few patches in there, as I've split the various parts into their individual components so its easier to track and submit. The patches include some back ported code that's already committed as well as other little fixes which also have been committed. Notes at the top of each patch file detail what it does and if its been committed. The one to watch is zfs-ashift-fix.patch as that changes how ashift is calculated for a drive (makes it compatible with QUIRKS) but could well cause issues if you booting from a ZFS tank which has a member disk that changes stripsize. If you don't want to risk that, just delete it. It should however be noted that at least on sandforce based disks if your deletes aren't 4k aligned the trim requests will be ignored by the drive, which is what triggered us to create that patch as well as the ssd_quirks.patch Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk.