Date: Sat, 16 Dec 1995 04:54:01 +1100 From: Bruce Evans <bde@zeta.org.au> To: CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, davidg@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa if_ed.c Message-ID: <199512151754.EAA24327@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
> Modified: sys/i386/isa if_ed.c > Log: > Changed arg type for pio functions. > Cast a few things appropriately to shut up the compiler. Please fix problems, not compiler warnings. In this case, I think the casts only work because the hardware ignores some bits in the address (bits 14-15 of 0-31 for 16K cards and bits 13-15 for 8K cards?). Conversions of the form (int)(buf - base) ((int)buf) & 0x3fff would be more obviously correct, but might be slower. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199512151754.EAA24327>