Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Jan 2007 13:12:58 +0100
From:      Alexander Leidinger <Alexander@Leidinger.net>
To:        Gabor Kovesdan <gabor@FreeBSD.org>
Cc:        "Eric P. Scott" <eps+pbug0611@ana.com>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/net/linux-nx-client Makefile distinfo pkg-plist         ports/net/linux-nx-client/files patch-nxclient-admin.desktop patch-nxclient-help.desktop         patch-nxclient-wizard.desktop patch-nxclient.desktop
Message-ID:  <20070126131258.30fic24gao8o44gc@webmail.leidinger.net>
In-Reply-To: <200701252300.l0PN0rsh064780@repoman.freebsd.org>
References:  <200701252300.l0PN0rsh064780@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Gabor Kovesdan <gabor@FreeBSD.org> (from Thu, 25 Jan 2007 =20
23:00:53 +0000 (UTC)):

> gabor       2007-01-25 23:00:52 UTC
>
>   FreeBSD ports repository
>
>   Modified files:
>     net/linux-nx-client  Makefile distinfo pkg-plist
>   Removed files:
>     net/linux-nx-client/files patch-nxclient-admin.desktop
>                               patch-nxclient-help.desktop
>                               patch-nxclient-wizard.desktop
>                               patch-nxclient.desktop
>   Log:
>   - Update to 2.1.0
>   - Move to LINUXBASE

I had a look at the changes and the entire plist. I think this belongs =20
into localbase instead. linuxbase is reserved for infrastructure ports =20
(e.g. libs). Stuff which is used directly by users is supposed to go =20
to localbase. The plist shows systems independend stuff in "ordianary" =20
directories, and the linux object specific stuff in a directory =20
(lib/linux-nx-client/) which makes it very hard to mistake it as =20
FreeBSD native stuff (it also contains some pictures, which don't =20
belong here but into share instead, but this is not high priority =20
stuff to fix). So I suggest to move it into localbase instead.

>   - Add USE_LDCONFIG

This is not ncessary here at all, as the linux libs are private ones =20
and are not in the default search path of the linux ldconfig.

Bye,
Alexander.

--=20
A bird in hand is safer than one overhead.

http://www.Leidinger.net    Alexander @ Leidinger.net: PGP ID =3D B0063FE7
http://www.FreeBSD.org       netchild @ FreeBSD.org  : PGP ID =3D 72077137



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070126131258.30fic24gao8o44gc>