Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 May 1997 06:23:21 +1000
From:      Bruce Evans <bde@zeta.org.au>
To:        cvs-all@freebsd.org, CVS-committers@freebsd.org, cvs-sys@freebsd.org, sos@freefall.FreeBSD.ORG
Subject:   Re: cvs commit:  src/sys/scsi sd.c
Message-ID:  <199705012023.GAA24197@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>  Modified:    sys/scsi  sd.c
>  Log:
>  Remove old code in #if 0, leftovers from the days before != 512byte
>  sector support.

Please put it back.  It shows more or less the correct way to do things,
which is to let dscheck() do all the checking for all disks.

The != 512byte sector support breaks at least EOF handling.  (dscheck()
rewrites both bp-b_resid and bp->b_bcount for transfers that cross the
end of the partition, but the != 512byte sector support does extra work
to prevent the change to bp->b_bcount.  I think it does this prevent
truncation giving a count that isn't a multiple of sec_blk_ratio.  I think
the count is always a multiple except for misconfigured partitions.
Partition sizes currently need to be multiples of sec_blk_ratio to
prevent this.  Partition sizes should really be in units of sectors.)

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199705012023.GAA24197>