Date: Thu, 16 Jan 2003 00:35:00 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Dag-Erling Smorgrav <des@ofug.org> Cc: arch@FreeBSD.ORG Subject: Re: Buglet in disklabel Message-ID: <20030116003206.C23422-100000@gamplex.bde.org> In-Reply-To: <xzp1y3e650n.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 15 Jan 2003, Dag-Erling Smorgrav wrote: > There's a bug in disklabel -e which manifests itself when you make a > mistake and re-edit the label. Under certain circumstances, it will > remember portions of an earlier version of the label, and reject a > valid label because of conflicts with the earlier version. > ... > I believe the attached patch fixes this problem, but I'd like a review > from someone more familiar with disklabel before I commit it. [Patch lost to attachment.] Looks good. You could also remove the bzero() before one of the calls to getasciilabel() (the one that passes a local variable that would more obviously be unitialized if it weren't bzero()ed). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030116003206.C23422-100000>