From owner-freebsd-arch Wed Jan 15 5:34: 6 2003 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FDCF37B401 for ; Wed, 15 Jan 2003 05:34:05 -0800 (PST) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6310443F5F for ; Wed, 15 Jan 2003 05:34:04 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id AAA05496; Thu, 16 Jan 2003 00:33:56 +1100 Date: Thu, 16 Jan 2003 00:35:00 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Dag-Erling Smorgrav Cc: arch@FreeBSD.ORG Subject: Re: Buglet in disklabel In-Reply-To: Message-ID: <20030116003206.C23422-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 15 Jan 2003, Dag-Erling Smorgrav wrote: > There's a bug in disklabel -e which manifests itself when you make a > mistake and re-edit the label. Under certain circumstances, it will > remember portions of an earlier version of the label, and reject a > valid label because of conflicts with the earlier version. > ... > I believe the attached patch fixes this problem, but I'd like a review > from someone more familiar with disklabel before I commit it. [Patch lost to attachment.] Looks good. You could also remove the bzero() before one of the calls to getasciilabel() (the one that passes a local variable that would more obviously be unitialized if it weren't bzero()ed). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message