From owner-freebsd-bugs@FreeBSD.ORG Thu Jan 12 05:00:26 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B4926106564A for ; Thu, 12 Jan 2012 05:00:26 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 69AE58FC12 for ; Thu, 12 Jan 2012 05:00:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0C50QM2073885 for ; Thu, 12 Jan 2012 05:00:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0C50QIX073876; Thu, 12 Jan 2012 05:00:26 GMT (envelope-from gnats) Resent-Date: Thu, 12 Jan 2012 05:00:26 GMT Resent-Message-Id: <201201120500.q0C50QIX073876@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Devin Teske Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A5DA106564A for ; Thu, 12 Jan 2012 04:54:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 8961A8FC08 for ; Thu, 12 Jan 2012 04:54:15 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0C4sFVp058932 for ; Thu, 12 Jan 2012 04:54:15 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q0C4sFC2058919; Thu, 12 Jan 2012 04:54:15 GMT (envelope-from nobody) Message-Id: <201201120454.q0C4sFC2058919@red.freebsd.org> Date: Thu, 12 Jan 2012 04:54:15 GMT From: Devin Teske To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/164038: [PATCH] tzsetup(8): Increase buffer size to hold error messages X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 05:00:26 -0000 >Number: 164038 >Category: bin >Synopsis: [PATCH] tzsetup(8): Increase buffer size to hold error messages >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jan 12 05:00:26 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Devin Teske >Release: FreeBSD 9.0-RELEASE amd64 >Organization: FIS Global, Inc. >Environment: FreeBSD scribe.vicor.com 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2010 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: The prompt buffer is too small to hold error messages, and thus simply executing "tzsetup some/foo" results in: Cannot read /usr/share/zoneinfo/some/foo: No such file or dir (truncated portion is "ectory") Bumping the prompt buffer from 64 bytes to 1024 seems like a modest solution. >How-To-Repeat: Exec as root: tzsetup some/foo Notice error message "Cannot read %s: No such file or directory" is truncated by the 64-byte buffer. >Fix: See attached patch.txt Patch attached with submission follows: --- usr.sbin/tzsetup/tzsetup.c.orig Fri Dec 2 11:19:10 2011 +++ usr.sbin/tzsetup/tzsetup.c Wed Jan 11 18:58:01 2012 @@ -638,7 +638,7 @@ static int install_zoneinfo_file(const char *zoneinfo_file) { char buf[1024]; - char title[64], prompt[64]; + char title[64], prompt[1024]; struct stat sb; ssize_t len; int fd1, fd2, copymode; >Release-Note: >Audit-Trail: >Unformatted: