Date: Mon, 26 Apr 2021 09:49:25 -0700
From: Neel Chauhan <nc@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
Cc: Shawn Webb <shawn.webb@hardenedbsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org
Subject: Re: git: 9db8b85a942d - stable/13 - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave()
Message-ID: <fe200346753753dd6978636a2299417c@freebsd.org>
In-Reply-To: <67e6aa7a-3c1d-1055-d468-b6a366382f04@FreeBSD.org>
References: <202104261545.13QFjAYB012989@gitrepo.freebsd.org> <20210426160242.7nddbshrccusdb5j@mutt-hbsd> <67e6aa7a-3c1d-1055-d468-b6a366382f04@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2021-04-26 09:42, John Baldwin wrote: > I agree. 20 minutes is far too short. The normal minimum is 3 days. > You already have feedback on the commits to main that you should > probably adjust before merging (specifically Mateusz's quite salient > point). > Requiring two immediate fixups to the original commit in main is also > indicative that the change in question isn't really ready yet. Sorry about this. I'm new(-ish?) to src. The immediate "fixups" are just formatting changes that were requested, not really bugfixes. -Neel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fe200346753753dd6978636a2299417c>