From owner-svn-ports-head@FreeBSD.ORG  Wed Jan 16 10:03:31 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 098F5761; Wed, 16 Jan 2013 10:03:31 +0000 (UTC)
Date: Wed, 16 Jan 2013 10:03:31 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Marcelo Araujo <araujo@FreeBSD.org>
Subject: Re: svn commit: r310483 - in head/devel/tpasm: . files
Message-ID: <20130116100330.GA12459@FreeBSD.org>
References: <201301160817.r0G8Hrws045649@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201301160817.r0G8Hrws045649@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jan 2013 10:03:31 -0000

On Wed, Jan 16, 2013 at 08:17:53AM +0000, Marcelo Araujo wrote:
> New Revision: 310483
> URL: http://svnweb.freebsd.org/changeset/ports/310483
> 
> Log:
>   - Update to 1.8.
>   - Trim header.

I must say I see a lot of gratuitous changes that 1) do not seem to improve
anything (yet recude readability); and 2) are not mentioned in the log.

>   PR:		ports/174183
>   Submitted by:	KATO Tsuguru <tkato432@yahoo.com>

Something unexpected from KATO-san. :(

>  do-install:
> -	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
> +	(cd ${WRKSRC} && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin)
>  	@${MKDIR} ${PREFIX}/libdata/${PORTNAME}
> -	${INSTALL_DATA} ${WRKSRC}/include/* ${PREFIX}/libdata/${PORTNAME}
> +	(cd ${WRKSRC}/include \
> +		&& ${INSTALL_DATA} * ${PREFIX}/libdata/${PORTNAME})
>  .if !defined(NOPORTDOCS)
>  	@${MKDIR} ${DOCSDIR}
> -	${INSTALL_DATA} ${WRKSRC}/CONVERSION_C166.TXT ${WRKSRC}/MANUAL.TXT \
> -		${WRKSRC}/README*.TXT ${DOCSDIR}
> +.for i in CONVERSION_C166.TXT MANUAL.TXT README*.TXT
> +	(cd ${WRKSRC} && ${INSTALL_DATA} ${i} ${DOCSDIR})
> +.endfor
>  .endif
>  .if !defined(NOPORTEXAMPLES)
>  	@${MKDIR} ${EXAMPLESDIR}
> -	${INSTALL_DATA} ${WRKSRC}/samples/* ${EXAMPLESDIR}
> +	(cd ${WRKSRC}/samples && ${INSTALL_DATA} * ${EXAMPLESDIR})
>  .endif

I am referring to this particualr part of the patch.  I will probably fix it
later if I happen to touch this port again.

./danfe