Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Aug 2017 22:36:44 +0200
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Dan Langille <dvl@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r448998 - head/net-mgmt/tcpreplay
Message-ID:  <1sns-okrn-wny@FreeBSD.org>
In-Reply-To: <201708301932.v7UJW1tH094312@repo.freebsd.org> (Dan Langille's message of "Wed, 30 Aug 2017 19:32:01 %2B0000 (UTC)")
References:  <201708301932.v7UJW1tH094312@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Dan Langille <dvl@FreeBSD.org> writes:

> Author: dvl
> Date: Wed Aug 30 19:32:00 2017
> New Revision: 448998
> URL: https://svnweb.freebsd.org/changeset/ports/448998
>
> Log:
>   Add base/port options for libpcap
[...]
> +OPTIONS_DEFINE=	LIBPCAP_BASE LIBPCAP_PORTS
[...]
> +OPTIONS_SINGLE=	SG1
> +OPTIONS_SINGLE=	LIBPCAP_BASE LIBPCAP_PORTS

_SINGLE declares a group of options, not the option themselves.
When _SINGLE is overloaded by _DEFINE the option is no longer exclusive.

Did you forget to adjust Porter's Handbook example?

OPTIONS_SINGLE=	LIBPCAP
OPTIONS_SINGLE_LIBPCAP=	LIBPCAP_BASE LIBPCAP_PORTS

> +OPTIONS_DEFAULT=	LIBPCAP_BASE

Doesn't work if net/libpcap is installed as a dependency by another
(unrelated) port.

> +LIBPCAP_PORTS_BUILD_DEPENDS=	${LOCALBASE}/lib/libpcap.a:net/libpcap
> +LIBPCAP_PORTS_LIB_DEPENDS=	libpcap.so:net/libpcap

Maybe drop _BUILD_DEPENDS hack by adding .1 suffix to _LIB_DEPENDS.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1sns-okrn-wny>