From owner-freebsd-stable  Mon Oct 15  9:15: 8 2001
Delivered-To: freebsd-stable@freebsd.org
Received: from earth.backplane.com (earth-nat-cw.backplane.com [208.161.114.67])
	by hub.freebsd.org (Postfix) with ESMTP
	id EF0D237B411; Mon, 15 Oct 2001 09:15:01 -0700 (PDT)
Received: (from dillon@localhost)
	by earth.backplane.com (8.11.6/8.11.2) id f9FGEwB55018;
	Mon, 15 Oct 2001 09:14:58 -0700 (PDT)
	(envelope-from dillon)
Date: Mon, 15 Oct 2001 09:14:58 -0700 (PDT)
From: Matt Dillon <dillon@earth.backplane.com>
Message-Id: <200110151614.f9FGEwB55018@earth.backplane.com>
To: Bruce Evans <bde@zeta.org.au>
Cc: <current@FreeBSD.ORG>, <stable@FreeBSD.ORG>, <alfred@FreeBSD.ORG>
Subject: Re: coredump() broken for nfs filesystems
References:  <20011015211333.B576-100000@delplex.bde.org>
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-stable.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable>
X-Loop: FreeBSD.ORG


:
:coredump() now usually creates empty core files for nfs filesystems.
:This seems to be caused by the changes in rev.1.132 (-current) and
:rev.1.72.2.9 (RELENG_4), and braindamage in nfs_dolock():

    I think if we change it to an flock() equivalent it should work.
    I'll play with it.

						-Matt

:Index: kern_sig.c
:===================================================================
:RCS file: /home/ncvs/src/sys/kern/kern_sig.c,v
:retrieving revision 1.131
:retrieving revision 1.132
:diff -u -2 -r1.131 -r1.132
:--- kern_sig.c	6 Sep 2001 22:20:41 -0000	1.131
:+++ kern_sig.c	8 Sep 2001 20:02:32 -0000	1.132
:> ...
:@@ -1896,6 +1898,17 @@
: 	NDFREE(&nd, NDF_ONLY_PNBUF);
: 	vp = nd.ni_vp;
:+
:+	VOP_UNLOCK(vp, 0, p);
:+	lf.l_whence = SEEK_SET;
:+	lf.l_start = 0;
:+	lf.l_len = 0;
:+	lf.l_type = F_WRLCK;
:+	error = VOP_ADVLOCK(vp, (caddr_t)p, F_SETLK, &lf, F_FLOCK);
:+	if (error)
:+		goto out2;
:+
:
:This usually goes to out2 with error EOPNOTSUPP if the core file is on
:an nfs filesystem.
:
:...

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message