From owner-svn-src-head@freebsd.org Mon Aug 27 15:31:38 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F19E6108DEDA; Mon, 27 Aug 2018 15:31:37 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 798F375BBA; Mon, 27 Aug 2018 15:31:37 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by mail-pf1-x444.google.com with SMTP id u24-v6so7891726pfn.13; Mon, 27 Aug 2018 08:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=poldrgs4P29ExumWgHfd6Uy7EocNJsCS4pr7BigPlfo=; b=c59nvC4+qwLlOg78ovjIa9tHcdospgccKOa3RyDpNCszqkkRrb4+3qdcVk7qLtFryN FWQVs7fdf/ks9M6aVSFQT/ot555lK1W4B6YEFK1i1j3nlJdxFF7BtJLxRhelYp4t1u80 6klzcC+GYyIFdZVSNcXybZwiqmZU4eN5gGqhbgvN65Dn1EE/4iYcNmLHdOYHoPELHX2U WI00yx64mjJqSbwltYJ2qPol7ElgDOG59w+rmVGVzKd9jrl063cbIJoEWVuY6efnOrQn gRWhFK3jBjdGplSLMNGHw91ePeUMUMYK/QtEB0AaWbSbACiZpq0qGfjXWA7yUMVBKhR3 bmHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=poldrgs4P29ExumWgHfd6Uy7EocNJsCS4pr7BigPlfo=; b=Clee5ex4gq3+bpwY5/x5XTtfYIwWCuBXcKxmXSMOMQeeKvX8xNoNRnWEtddFxqJkBd T1JvvmIm6Z5JqJMxF4SHH7FDVchrHs3RimhH0Xh3kKIjOxvE2RwqHtZ77RFwz8qnwEAA co7HyF4sNt9MwJUm1aWobJWjFU7JcuXfI/1EcMidnkrHgD7J/M9mYLoDv5M7BCSsnPrL 53Z5bCzE1YXUkZKGlLXGznfH3og3pK1YZX11yk4sAsxkTTcKmRqCptolOvJ6V8Niv0oJ fLF0FztNlPAuGpE4w7cUK6VuTNXP7FrkQfo/YG+6vP0usN7XcqmBnobGgybK9dwO3W8r FWOA== X-Gm-Message-State: APzg51D4DJ7ziKjcFvO2zk7OQ1/LMuLnsdhPgD+Z2ur/wSARn8s+7FHL BQjEtPeYzJmlsDJKkKzuiShCH0/X X-Google-Smtp-Source: ANB0VdYNc66zvGlXLIRAFFxwt298P7pt0jmcC8oePo891u0o5nbeQGt1nlk4qa6zV42p3whp9dRGvQ== X-Received: by 2002:a63:5fc8:: with SMTP id t191-v6mr12744909pgb.183.1535383896011; Mon, 27 Aug 2018 08:31:36 -0700 (PDT) Received: from ox ([2601:641:c000:b800:55d6:510e:316b:dc20]) by smtp.gmail.com with ESMTPSA id g5-v6sm20791567pgn.73.2018.08.27.08.31.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Aug 2018 08:31:34 -0700 (PDT) Sender: Navdeep Parhar Date: Mon, 27 Aug 2018 08:31:32 -0700 From: Navdeep Parhar To: Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337943 - head/sys/net Message-ID: <20180827153132.GB10167@ox> Mail-Followup-To: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201808170103.w7H13Nl5047960@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2018 15:31:38 -0000 On Mon, Aug 27, 2018 at 12:18:02PM +0200, Hans Petter Selasky wrote: > On 8/17/18 3:03 AM, Navdeep Parhar wrote: > > Author: np > > Date: Fri Aug 17 01:03:23 2018 > > New Revision: 337943 > > URL: https://svnweb.freebsd.org/changeset/base/337943 > > > > Log: > > if_vlan(4): A VLAN always has a PCP and its ifnet's if_pcp should be set > > to the PCP value in use instead of IFNET_PCP_NONE. > > MFC after: 1 week > > Sponsored by: Chelsio Communications > > > > Modified: > > head/sys/net/if_vlan.c > > > > Modified: head/sys/net/if_vlan.c > > ============================================================================== > > --- head/sys/net/if_vlan.c Fri Aug 17 00:49:35 2018 (r337942) > > +++ head/sys/net/if_vlan.c Fri Aug 17 01:03:23 2018 (r337943) > > @@ -1435,6 +1435,7 @@ vlan_config(struct ifvlan *ifv, struct ifnet *p, uint1 > > ifp->if_resolvemulti = p->if_resolvemulti; > > ifp->if_addrlen = p->if_addrlen; > > ifp->if_broadcastaddr = p->if_broadcastaddr; > > + ifp->if_pcp = ifv->ifv_pcp; > > /* > > * Copy only a selected subset of flags from the parent. > > @@ -1959,6 +1960,7 @@ vlan_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data > > break; > > } > > ifv->ifv_pcp = ifr->ifr_vlan_pcp; > > + ifp->if_pcp = ifv->ifv_pcp; > > vlan_tag_recalculate(ifv); > > /* broadcast event about PCP change */ > > EVENTHANDLER_INVOKE(ifnet_event, ifp, IFNET_EVENT_PCP); > > Hi Navdeep, > > FYI: This patch currently breaks OFED, because OFED doesn't expect > if_pcp to be different from the NONE value with VLAN interfaces. It turns out that the patch broke VLANs without OFED too, but that part was fixed in r338305. > > Mellanox is working on a fix. Ok, thanks. Looks like rdma_vlan_dev_vlan_id might need to check for if_type == IFT_L2VLAN rather than the if_pcp. Let me know in case you need any help. Regards, Navdeep