From owner-freebsd-hackers@freebsd.org Sun Sep 1 19:48:43 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EADBFE3434; Sun, 1 Sep 2019 19:48:43 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46M3gG25tNz3FkW; Sun, 1 Sep 2019 19:48:41 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id 4Vq2iomg5SrVc4Vq3i7K7H; Sun, 01 Sep 2019 13:48:40 -0600 X-Authority-Analysis: v=2.3 cv=L5ZjvNb8 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=8nJEP1OIZ-IA:10 a=J70Eh1EUuV4A:10 a=pGLkceISAAAA:8 a=ndaoGXS1AAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=Md3c0C-VMmJUd6EbHGwA:9 a=wPNLvfGTeEIA:10 a=mFeOnlTyF09QQMGr2mMI:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=pHzHmUro8NiASowvMSCR:22 a=nt3jZW36AmriUCFCBwmW:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id AC31F52F; Sun, 1 Sep 2019 12:48:37 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x81Jmb1F004577; Sun, 1 Sep 2019 12:48:37 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x81JmbS3004574; Sun, 1 Sep 2019 12:48:37 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201909011948.x81JmbS3004574@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Enji Cooper cc: Hans Petter Selasky , FreeBSD Hackers , Ed Maste , Li-Wen Hsu , Warner Losh , fcp@freebsd.org Subject: Re: FCP 20190401-ci_policy: CI policy In-reply-to: <8350379A-30F8-4BBD-B9AE-A3A176CAE966@gmail.com> References: <20190829114057.GZ71821@kib.kiev.ua> <20190830065534.GC71821@kib.kiev.ua> <73111.1567263258@kaos.jnpr.net> <44a1a905-9b35-620b-281c-cdbbee538bed@selasky.org> <8350379A-30F8-4BBD-B9AE-A3A176CAE966@gmail.com> Comments: In-reply-to Enji Cooper message dated "Sun, 01 Sep 2019 12:33:59 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Date: Sun, 01 Sep 2019 12:48:37 -0700 X-CMAE-Envelope: MS4wfCrMO035lM0dbVhdcElgsSQ9coc6bsGgGX45zxaPIrV21CXLnHDXA1RaxhNPq5QEvRCatJAvady2ql0i0cUPZ+WL+kFhoxmFl3BJ11di9I8PXC2vS379 9OAxUlERUBB1jTedeQQDrTyKXilU2KMLAtRoxMZe4n7PfG/3a8ZoyOmD6AGvLHedXM1wLKjUWvHZQiiFaXXA4VCs467pFJWgVxT4fpt/Eh5+X+fODCUSboka xOuCAHkVB/vUdXeQyVJSGmb32lKKH9L7bak7X6ZgKWwvurQwwa7KLmO5UYxMpuSbKvQn0ImfG+isKPg6JqVXYg== X-Rspamd-Queue-Id: 46M3gG25tNz3FkW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.136.138) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-4.93 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; REPLYTO_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.958,0]; RCVD_IN_DNSWL_NONE(0.00)[138.136.59.64.list.dnswl.org : 127.0.5.0]; RCPT_COUNT_SEVEN(0.00)[7]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-2.37)[ip: (-6.21), ipnet: 64.59.128.0/20(-3.12), asn: 6327(-2.42), country: CA(-0.09)]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2019 19:48:44 -0000 In message <8350379A-30F8-4BBD-B9AE-A3A176CAE966@gmail.com>, Enji Cooper writes : > > > > On Sep 1, 2019, at 10:42 AM, Hans Petter Selasky wrote: > > > > Hi, > > > > If the fallouts could be better organized through some simple guidelines, t > hat would be more accepted I think: > > > > 1) Don't commit stuff before going off work. Even though a change looks inn > ocent, it might break something and you'll need to fix it. > > > > 2) Organize big changes going into the kernel, to ease debugging and gettin > g things back on track again. > > > > 3) If your patch is risky, commit it on a Monday. Don't wait until Friday. > > > > Failure to follow the rules may have consequences like other senior develop > ers kicking in and doing temporary reverts until issues are resolved. > > Agreed. There’s a reason why at my most former job (FB) we generally knew b > etter than to commit code on a Friday. It would cause the weekend oncalls a l > ot of grief. > > Let’s put it this way: think of it like being oncall for code. If you don†> ™t have someone else to work with who can manage it, would you like to be pag > ed if something went south with your code committed on a Friday? This is a good idea. Pinging someone to provide backup support is a good idea. phk@ has asked me in this regard once giving me authority to back out his commit should it cause any grief. It didn't break anything but he made contingency plans just in case. > > Cheers, > -Enji -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.