Date: Thu, 17 Jan 2002 13:37:09 -0800 From: "Kevin Oberman" <oberman@ptavv.es.net> To: bmah@FreeBSD.org Cc: "M. Warner Losh" <imp@village.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/sio sio.c Message-ID: <20020117213709.DBCAE5D13@ptavv.es.net> In-Reply-To: Your message of "Thu, 17 Jan 2002 09:52:06 PST." <200201171752.g0HHq6s32212@bmah.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> From: bmah@FreeBSD.org (Bruce A. Mah)
> Date: Thu, 17 Jan 2002 09:52:06 -0800
> Sender: bmah@employees.org
>
> If memory serves me right, "M. Warner Losh" wrote:
>
> > : It's a support issue. I don't object real strongly to backing out the
> > : "port may be disabled" message but the way that the sio probe claimed a
> > : disabled port was really an 8250 was pretty bogus and has bitten a bunch
> > : of people (me included). So I think that some form of the second hunk
> > : of the patch should stay in.
> >
> > That part of the patch I have no problems with (it is correct, and the
> > only slight bogon in it is that maybe the the hardware is at that
> > address, but not a UART at all :-). It is the part that says that it
> > may be disabled in the BIOS. That's only one of a long list of
> > reasons... The SIO driver is used on non-intel hardware, and some of
> > that hardware doesn't even have a BIOS in the traditional intel sense
> > :-)
> >
> > Like I said, it was the wording of the message....
>
> OK, sounds good. When I get around to it (later today), I'll change it
> to just say "port may be disabled" (full stop). This time I'll pay
> attention to the dmesg output too. :-)
>
> Thanks,
>
> Bruce.
Sorry for inadequately testing the patch. It was so simple and my
trivial test worked fine.
I will try to send an update for the man page, but I am in the hospital
at the moment and may not be able to ge it done as quickly as I would
like.
Here is a corrected patch.
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: oberman@es.net Phone: +1 510 486-8634
--[[text/plain; type=patch
Content-Disposition: attachment; filename="sio.c.diff"][8bit]]
--- sio.c.orig Sun Jan 13 11:13:51 2002
+++ sio.c Thu Jan 17 13:28:22 2002
@@ -1008,10 +1008,14 @@
irqs = irqmap[1] & ~irqmap[0];
if (bus_get_resource(idev, SYS_RES_IRQ, 0, &xirq, NULL) == 0 &&
- ((1 << xirq) & irqs) == 0)
+ ((1 << xirq) & irqs) == 0) {
printf(
"sio%d: configured irq %ld not in bitmap of probed irqs %#x\n",
device_get_unit(dev), xirq, irqs);
+ printf(
+ "sio%d: Port may not be enabled\n",
+ deveice_get_unit(dev));
+ }
if (bootverbose)
printf("sio%d: irq maps: %#x %#x %#x %#x\n",
device_get_unit(dev),
@@ -1226,7 +1230,7 @@
scr2 = sio_getreg(com, com_scr);
sio_setreg(com, com_scr, scr);
if (scr1 != 0xa5 || scr2 != 0x5a) {
- printf(" 8250");
+ printf(" 8250 or no response");
goto determined_type;
}
}
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020117213709.DBCAE5D13>