Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Sep 2009 22:13:47 +0200
From:      Juergen Lock <nox@jelal.kn-bremen.de>
To:        Anthony Liguori <anthony@codemonkey.ws>
Cc:        freebsd-emulation@freebsd.org, qemu-devel@nongnu.org
Subject:   Re: [Qemu-devel] ANNOUNCE: Release 0.11.0-rc2 of QEMU
Message-ID:  <20090904201347.GA77929@triton8.kn-bremen.de>
In-Reply-To: <4AA11B9F.9050101@codemonkey.ws>
References:  <4AA11B9F.9050101@codemonkey.ws>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 04, 2009 at 08:52:31AM -0500, Anthony Liguori wrote:
> The QEMU team is pleased to announce the availability of the 0.11.0-rc2
> release.  This is the second release candidate for the 0.11.0 release.
> This release contains only bug fixes since 0.11.0-rc1.
> 
> Any bugs can be reported at http://bugs.launchpad.net/qemu/+bugs
> 
> It can be downloaded from Savannah at:
> 
> http://download.savannah.gnu.org/releases/qemu/qemu-0.11.0-rc2.tar.gz
> 
Since I already made an experimental FreeBSD qemu-devel port update
for 0.11.0 rc1 updating that to 0.11.0 rc2 was easy:
	http://people.freebsd.org/~nox/qemu/qemu-devel-0.11.0r2.patch
(I changed two things tho, see below.)

> The following fixes have been added since qemu-0.11.0-rc1:
> 
>    - mips: fix conditional move off fp conditions codes (Nath Froyd)
>    - fix migration to obey -S (Paolo Bonzini)
>    - remove pc-0-10 machine type (Mark McLoughlin)
>    - vnc: fix copyrect screen corruption (Gerd Hoffman)
>    - fix vm state change handlers running order (Markus Armbruster)
>    - e1000: fix eerc and ics emulation (Bill Paul)
>    - fix sdl zooming with pl110 (Blue Swirl)
>    - sparc64: flush pending conditional evaluations (Igor Kovalenko)
>    - esp: fix interrupt register read (Blue Swirl)
>    - option rom makefile fixes (Paul Brook)
>    - fix sparse warnings (Blue Swirl)
>    - fix symfind (Laurent Desnogues)
>    - win32: fix default prefix (Stefan Weil)
>    - fix checksum writing in signboot (Alex Graf)
>    - fix sdl window resize (Stefano Stabellini)
>    - do not resize the screen on hw_invalidate (Stefano Stabellini)
>    - Add checks for -smbios option (Beth Kon)
>    - fix do_set_link (Luiz Capitulino)
>    - fix do_commit behavior (Luiz Capitulino)
>    - make windows notice media change (Gleb Natapov)
>    - check for PR_SET_NAME being defined (Nathan Froyd)
>    - fix migration for ide devices (Anthony Liguori)
>    - Use correct depth in vmware vga (Reimar Doffiner)

 This seems to work well, I now can run a Linux iso with -vga vmware
and vmmouse and set all kinds of resolutions in the guest using xrandr.
Thanx!

>    - support 32bpp cursors in sdl (Reimar Doffinger)
>    - fix device name completion for eject (Blue Swirl)
>    - make screendump use DisplayState properly (Stefano Stabellini)
>    - fix autostart with live migration (Avi Kivity)
>    - fix detached migration with exec (Chris Lalancette)
>    - fix segv when changing vnc password in sdl (Zach Amsden)
>    - fix vnc password clearing with stdio monitor (Zach Amsden)
>    - clean up VGA type selection (Zach Amsden)
>    - add missing linefeed in error message (Stefan Weil)

 Ok now what I changed:  I removed the dynticks patch since it seems to
perform even worse than -clock unix on FreeBSD (does this count as a
qemu bug?  The problem seems to be that FreeBSD's POSIX `realtime'
timers still only count in increments of HZ, and then seem to always
round up too.)  And -clock unix is only marginally better, see
my post here:
	http://lists.gnu.org/archive/html/qemu-devel/2009-09/msg00049.html
(well at least its good enough that Linux guest kernels don't fail to
boot like with -clock dynticks.)

 The second change is a small patch to tap_cleanup that makes it close
the tap fd before calling the ifdown script instead of after, otherwise
FreeBSD's tap driver may hit a KASSERT in case the ifdown script does
something like an `ifconfig tap0 destroy'...

Index: qemu/net.c
@@ -1643,12 +1643,13 @@ static void tap_cleanup(VLANClientState 
 
     qemu_purge_queued_packets(vc);
 
-    if (s->down_script[0])
-        launch_script(s->down_script, s->down_script_arg, s->fd);
-
     tap_read_poll(s, 0);
     tap_write_poll(s, 0);
     close(s->fd);
+
+    if (s->down_script[0])
+        launch_script(s->down_script, s->down_script_arg, -1);
+
     qemu_free(s);
 }
 
 I don't know if there are use cases where the ifdown script needs the
tap fd still open, otherwise I guess this can also be committed upstream.
And in case you want to: :)

 Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090904201347.GA77929>