Date: Thu, 26 Oct 2006 15:37:54 GMT From: Jordan Gordeev<jgordeev@dir.bg> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/104831: [patch] A bug in net/dhcpdump when decoding FQDN DHCP option Message-ID: <200610261537.k9QFbsEn074109@www.freebsd.org> Resent-Message-ID: <200610261540.k9QFeIuk085894@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 104831 >Category: ports >Synopsis: [patch] A bug in net/dhcpdump when decoding FQDN DHCP option >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Oct 26 15:40:17 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Jordan Gordeev >Release: FreeBSD 6.1-RELEASE-p10 >Organization: >Environment: >Description: A bug exists in the code of net/dhcpdump (dhcpdump-1.7) handling decoding and printing of the FQDN DHCP option. The bug looks like a typo. The attached patch fixes it. An attempt to contact the maintainer, which is also the author, was unsuccessful. >How-To-Repeat: Monitor DHCP traffic on a network. Look for the way the FQDN DHCP option is printed. >Fix: Patch attached with submission follows: --- dhcpdump.c.old Sat Oct 14 12:11:17 2006 +++ dhcpdump.c Sat Oct 14 12:11:35 2006 @@ -449,7 +449,7 @@ print8bits(data+j+4); printf(" "); strncpy(buf,&data[j+5],data[j+1]-3); - buf[data[j+1-3]]=0; + buf[data[j+1]-3]=0; printf("%s",buf); break; >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610261537.k9QFbsEn074109>