From owner-dev-commits-ports-all@freebsd.org Mon Apr 12 21:41:59 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8D1C25DFD15; Mon, 12 Apr 2021 21:41:59 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FK2J73dLRz3CCZ; Mon, 12 Apr 2021 21:41:59 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from mandree.no-ip.org (p200300d0270ed10084169c82436dcf7a.dip0.t-ipconnect.de [IPv6:2003:d0:270e:d100:8416:9c82:436d:cf7a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mandree/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 576A4250A8; Mon, 12 Apr 2021 21:41:59 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from ryzen.an3e.de (localhost [IPv6:::1]) by ryzen.an3e.de (Postfix) with ESMTP id 631FF122DC7; Mon, 12 Apr 2021 23:41:58 +0200 (CEST) Subject: Re: git: 50731b13c882 - main - devel/kf5-extra-cmake-modules: make compatible with OpenEXR/Imath 3.0 To: Adriaan de Groot , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202104120034.13C0YB4k092091@gitrepo.freebsd.org> <2440935.0dHE6SNnxz@beastie.bionicmutton.org> From: Matthias Andree Message-ID: <51e76378-549f-978f-0442-a9802fcf8c4a@FreeBSD.org> Date: Mon, 12 Apr 2021 23:41:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <2440935.0dHE6SNnxz@beastie.bionicmutton.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Apr 2021 21:41:59 -0000 Am 12.04.21 um 11:18 schrieb Adriaan de Groot: > On Monday, 12 April 2021 02:34:11 CEST Matthias Andree wrote: >> devel/kf5-extra-cmake-modules: make compatible with OpenEXR/Imath 3.0 > > Have you tried upstreaming any of this? It *seems* like adjusting-to-Imath is > required to build against OpenEXR 3.0, and in due course everyone (that is, us > and the Linux world) is going to have that, so upstream needs to adjust > anyway. Hi Adrian, I haven't yet, but we should try to do that, and we should also approach the Academy Software Foundation to ask them to provide a canonical cmake find module, I've seen too many diverse approaches. pkg-config might actually be simplest, most GNU autoconf based ports use that and they have been a lot easier to update. I think there was some copying going on from the OpenEXR-finder-for-cmake from Blender, and lots of homebrewn stuff... too much freedom in mmake. > (Of course, upstreaming means dealing with both old- and new-OpenEXR and > handling paths and builds nicely) Exactly the reason why I've for now patched our ports locally first, to avoid a chicken-and-hen circular dependency... Cheers, Matthias