Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Dec 2011 12:39:14 -0800
From:      Doug Barton <dougb@FreeBSD.org>
To:        Eitan Adler <eadler@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r228790 - in head/usr.sbin: fwcontrol newsyslog ypserv
Message-ID:  <4EF243F2.7030000@FreeBSD.org>
In-Reply-To: <201112212027.pBLKRfPK084637@svn.freebsd.org>
References:  <201112212027.pBLKRfPK084637@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12/21/2011 12:27 PM, Eitan Adler wrote:
> Author: eadler (ports committer)
> Date: Wed Dec 21 20:27:41 2011
> New Revision: 228790
> URL: http://svn.freebsd.org/changeset/base/228790
> 
> Log:
>   - Remove extraneous null ptr deref checks

A better way to write this commit log would be, "Remove null pointer
checks that are extraneous because ..."  2/3 why, 1/3 what.

>   - Fix memory leak

Should this perhaps have been a separate commit?


Doug

-- 

		[^L]

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EF243F2.7030000>