From owner-svn-src-all@FreeBSD.ORG Wed Sep 24 15:04:36 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A4277770; Wed, 24 Sep 2014 15:04:36 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7B6AA9EA; Wed, 24 Sep 2014 15:04:36 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 781CBB995; Wed, 24 Sep 2014 11:04:35 -0400 (EDT) From: John Baldwin To: Konstantin Belousov Subject: Re: svn commit: r272032 - head/sys/conf Date: Wed, 24 Sep 2014 10:58:11 -0400 Message-ID: <18894593.erVri7Abnd@ralph.baldwin.cx> User-Agent: KMail/4.10.5 (FreeBSD/10.0-STABLE; KDE/4.10.5; amd64; ; ) In-Reply-To: <20140924142339.GJ8870@kib.kiev.ua> References: <201409231704.s8NH4Lcv098184@svn.freebsd.org> <8280436.uSRo73F0Mt@ralph.baldwin.cx> <20140924142339.GJ8870@kib.kiev.ua> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 24 Sep 2014 11:04:35 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bryan Drewery X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2014 15:04:36 -0000 On Wednesday, September 24, 2014 05:23:39 PM Konstantin Belousov wrote: > On Wed, Sep 24, 2014 at 09:58:07AM -0400, John Baldwin wrote: > > On Tuesday, September 23, 2014 09:44:34 PM Konstantin Belousov wrote: > > > On Tue, Sep 23, 2014 at 01:31:42PM -0500, Bryan Drewery wrote: > > > > On 9/23/2014 1:20 PM, Konstantin Belousov wrote: > > > > > On Tue, Sep 23, 2014 at 05:04:21PM +0000, Bryan Drewery wrote: > > > > >> Author: bdrewery > > > > >> Date: Tue Sep 23 17:04:21 2014 > > > > >> New Revision: 272032 > > > > >> URL: http://svnweb.freebsd.org/changeset/base/272032 > > > > >> > > > > >> Log: > > > > >> DEBUG_LOCKS no longer modifies 'struct vnode', nor does fstat(1) > > > > >> use > > > > >> it. > > > > >> fstat(1) now uses libprocstat(9). There is no userland impact to > > > > >> using this.> > > > > > > > > > > > DEBUG_VFS_LOCKS does modify KBI of VFS, by adding struct stack to > > > > > lockmgr, and lockmgr is embedded into each struct vnode. > > > > > > > > > > VFS modules, in particular, filesystems, compiled for mismatched > > > > > kernel WRT DEBUG_VFS_LOCKS, would cause strange breakage. > > > > > > > > Well, perhaps the comment needs to be updated to state that > > > > DEBUG_VFS_LOCKS modifies VFS KBI so any VFS modules will need to > > > > recompiled. > > > > > > > > I did see the stack was moved to lockmgr, but given the use of > > > > libprocstat, and lockmgr being a kernel struct, I don't think it's > > > > worth > > > > mentioning userland here. > > > > > > > > Sound good? > > > > > > I agree, I do not think that userland is affected. > > > > It is for at least lsof (which does not use libprocstat and cannot easily > > be adopted to use it exclusively as it pulls a lot more data out than > > libprocstat exports such as the info about file locks, etc.) > > We cannot seriously consider the lsof as application which uses > stable interfaces. I.e., binary incompatibility for lsof even > on the stable branch or on -pX is not an issue. > > Lsof verifies kernel release name and warns if it differs from the > one used at the compilation time, rightfully. I don't disagree. Just noting that it is a commonly-used tool that is affected by DEBUG_LOCKS. -- John Baldwin