Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 May 2004 17:47:24 +0200
From:      Brad Knowles <brad.knowles@skynet.be>
To:        =?iso-8859-1?Q?S=F8ren?= Schmidt <sos@DeepCore.dk>
Cc:        current@FreeBSD.ORG
Subject:   Re: Updated SATA support patches for Intel ICH & Promise cards
Message-ID:  <p06002015bcbebc486841@[10.0.1.2]>
In-Reply-To: <40990479.6070809@DeepCore.dk>
References:  <200405041825.i44IPgVa021573@ambrisko.com> <4097F9EA.1080904@DeepCore.dk> <20040505124349.GA612@VARK.homeunix.com> <40990479.6070809@DeepCore.dk>

next in thread | previous in thread | raw e-mail | index | archive | help
At 5:12 PM +0200 2004/05/05, Søren Schmidt wrote:

>  These patches are not really combineable since I've done things
>  differently and IMHO the way ATA wants it. What I would find usefull
>  would be the code to handle the AMI? RAID type as I havn't got any
>  HW with that one handy to test on, but if thats not to be unless the
>  patch at hand goes in, well...
>
>  BTW doug's patches doesn't solve the missing interrupt problem
>  unless I've missed it in the patch.

	I think the point was that Doug tried to follow your style, and 
you feel that he failed to do so resulting in patches that can't be 
combined with your work.  Your reaction to Doug and the way you have 
treated him are very discouraging, thus helping to ensure that he 
does not make any further attempts to help you on this subject.

	If you could be more constructive in your criticism of Doug and 
help him to better understand what it is you're looking for in the 
way of style, then he'd be in a better position to help you fix 
certain things and give you more time to work in other areas where he 
is not.

-- 
Brad Knowles, <brad.knowles@skynet.be>

"They that can give up essential liberty to obtain a little temporary
safety deserve neither liberty nor safety."
     -Benjamin Franklin, Historical Review of Pennsylvania.

   SAGE member since 1995.  See <http://www.sage.org/>; for more info.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p06002015bcbebc486841>